Bug 204132

Summary: [PATCH] devel/pysvn: update to 1.8.0 and unbreak port
Product: Ports & Packages Reporter: Matthias Petermann <matthias>
Component: Individual Port(s)Assignee: William Grzybowski <wg>
Status: Closed FIXED    
Severity: Affects Some People CC: mickael.maillot, nagy.attila, wg
Priority: --- Keywords: needs-qa, patch
Version: LatestFlags: bugzilla: maintainer-feedback? (nagy.attila)
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch file to upgrade pysvn to 1.8.0 and remove broken flag koobs: maintainer-approval+

Description Matthias Petermann 2015-10-29 19:17:30 UTC 
Created attachment 162577 [details]
Patch file to upgrade pysvn to 1.8.0 and remove broken flag

This port was marked as broken in r400156 because of this build errors:

pysvn_client_cmd_info.cpp:1383:39: error: use of undeclared identifier 'svn_sort__hash'
pysvn_client_cmd_info.cpp:1388:41: error: subscript of pointer to incomplete type 'const svn_sort__item_t'
pysvn_client_cmd_info.cpp:1389:62: error: member access into incomplete type 'const svn_sort__item_t'
pysvn_client_cmd_info.cpp:1392:65: error: member access into incomplete type 'const svn_sort__item_t'

According [1] it turns out the problem was introduced at the time devel/subversion was changed to 1.9.2.

Upgrading pysvn to version 1.8.0 (newest version) solves the build problem.

Attached is a patch to do this change.

Thanks & best regards,
Matthias


[1] http://mail-archives.us.apache.org/mod_mbox/subversion-users/201411.mbox/%3C545A8A09.1030509@reser.org%3E
Comment 1 nagy.attila 2015-11-01 19:13:48 UTC 
(In reply to Matthias Petermann from comment #0)
Hi,

Fine with me, thanks.
Comment 2 mickael.maillot 2015-11-13 16:54:23 UTC 
can you add:
${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/${PORTNAME}/*.so

at the and of the do-install to strip the lib ?
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-11-15 11:26:20 UTC 
A commit references this bug:

Author: wg
Date: Sun Nov 15 11:26:01 UTC 2015
New revision: 401690
URL: https://svnweb.freebsd.org/changeset/ports/401690

Log:
  devel/pysvn: update to 1.8.0

  - Unbreak build

  PR:		204132
  Submitted by:	Matthias Petermann
  Approved by:	maintainer
  MFH:		2015Q4

Changes:
  head/devel/pysvn/Makefile
  head/devel/pysvn/distinfo
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-11-15 12:17:35 UTC 
A commit references this bug:

Author: wg
Date: Sun Nov 15 12:16:52 UTC 2015
New revision: 401700
URL: https://svnweb.freebsd.org/changeset/ports/401700

Log:
  MFH: r401690

  devel/pysvn: update to 1.8.0

  - Unbreak build

  PR:		204132
  Submitted by:	Matthias Petermann
  Approved by:	portmgr

Changes:
_U  branches/2015Q4/
  branches/2015Q4/devel/pysvn/Makefile
  branches/2015Q4/devel/pysvn/distinfo