Bug 204138
| Summary: | multimedia/tvheadend support for hdhomerun | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Karsten Schmidt <bsd> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Bernhard Froehlich <decke> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | rocky | ||||||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(decke) |
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 162710 [details]
Improved patch
libhdhomerun_20150826.tgz is added as a distfile
Created attachment 162711 [details]
Removed .orig files from patch
And without old .orig files in the patch :)
There are a few things that I want to clarify before I can commit that patch. - Why do you explicitly set DISTFILES and EXTRACT_ONLY? This is auto generated from USE_GITHUB and seems too intrusive to me. - For the Makefile.hdhomerun patch why can't we set TVHEADEND_FILE_CACHE and place that distfile in that directory so that the code can remain as it is? - The sed replacement is a candidate for a line in the port Makefile under post-patch libhdhomerun is now in the ports tree (multimedia/libhdhomerun) so tvheadend can enable support without having to build a static version. I'm attaching a patch to add a new HDHOMERUN build option (enabled by default). Created attachment 165851 [details]
Patch to add HDHomeRun option (enabled by default)
A commit references this bug: Author: decke Date: Wed Jan 20 10:46:08 UTC 2016 New revision: 406743 URL: https://svnweb.freebsd.org/changeset/ports/406743 Log: - Add HDHomeRun support and enable by default - Bump PORTREVISION PR: ports/204138 Submitted by: sam@middling.me.uk Changes: head/multimedia/tvheadend/Makefile Good work, thanks! It's committed now. |
Created attachment 162591 [details] hdhomerun support Add an option to compile with libhdhomerun support.