Bug 204179
| Summary: | [patch] science/libint: enabling library options | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Johannes M Dieterich <jmd> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | danfe, koobs, miwi | ||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thanks for your contribution Dieterich.
On initial review, the MOPTION conditionals need to turned into "OPTIONS helpers":
<OPTION>_CONFIGURE_{ON,ENABLE,WITH} = <value>
Please see /usr/ports/Mk/bsd.options.mk for usage details, along with:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-options - Section: 5.12.3. Options Helpers
Along with --enabling the options, it is highly recommended to explicitly --disable-* options when the options are off.
Regarding wanting/needing to run autoreconf, you can use USES=autoreconf for this, please see: /usr/ports/Mk/uses/autoreconf.mk for usage details
Also option OPTDEBUG should be renamed to the standard "DEBUG". DEBUG_DESC isnt needed then, as it is already set in Mk/bsd.options.desc.mk Created attachment 162688 [details]
svn diff for science/libint (version 2)
Thanks for your comments! Except for the autoreconf, this new patch version implements your suggestions, I think.
@Dieterich, you don't want to use USES=autoreconf counter to my understanding of comment #0? Can you elaborate on the rationale? .. Please also confirm this passes QA successfuly (portlint, poudriere testport) A commit references this bug: Author: danfe Date: Mon Mar 20 03:20:14 UTC 2017 New revision: 436530 URL: https://svnweb.freebsd.org/changeset/ports/436530 Log: - Introduce couple of useful mathematical options and debugging support - Respect CFLAGS/CXXFLAGS (when building the port in release mode) PR: 204179 Changes: head/science/libint/Makefile |
Created attachment 162646 [details] svn diff for science/libint Find attached a patch exposing three options of the library: * debug (interesting for developers writing code against libint) * derivatives * R12 type integrals Please note that this port seems to expose an interesting edge case in the ports tree. Namely, the patch to configure.in is NOT needed if aclocal && autoconf are run [deprecated to use] but in the now recommended autoreconf && GNU_CONFIGURE, it is needed. Hence, I closed my pull request with upstream on this. The newer version of this library (libint2) is also plagued by this problem and cannot be as easily patched as this version.