Bug 204253
| Summary: | usr/src/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_partition_tbl.c:319: bad if test ? | ||
|---|---|---|---|
| Product: | Base System | Reporter: | David Binderman <dcb314> |
| Component: | misc | Assignee: | Andriy Voskoboinyk <avos> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | avos |
| Priority: | --- | Flags: | avos:
mfc-stable12+
avos: mfc-stable11+ avos: mfc-stable10+ |
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
A commit references this bug: Author: avos Date: Mon Feb 18 03:23:11 UTC 2019 New revision: 344245 URL: https://svnweb.freebsd.org/changeset/base/344245 Log: snmp_hostres(3): fix a typo in sanity checks in handle_chunk() PR: 204253 Submitted by: David Binderman <dcb314@hotmail.com> MFC after: 5 days Changes: head/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_partition_tbl.c A commit references this bug: Author: avos Date: Mon Mar 4 03:38:44 UTC 2019 New revision: 344747 URL: https://svnweb.freebsd.org/changeset/base/344747 Log: MFC r344245: snmp_hostres(3): fix a typo in sanity checks in handle_chunk() PR: 204253 Submitted by: David Binderman <dcb314@hotmail.com> Changes: _U stable/10/ stable/10/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_partition_tbl.c _U stable/11/ stable/11/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_partition_tbl.c _U stable/12/ stable/12/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_partition_tbl.c |
[usr/src/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_partition_tbl.c:319]: (warning) Char literal compared with pointer 'chunk_name'. Did you intend to dereference it? Source code is if (chunk_name == NULL || chunk_name == '\0') Maybe better code if (chunk_name == NULL || chunk_name[0] == '\0')