Bug 204312

Summary: multimedia/mkvtoolnix: update to 8.5.2
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Max Brazhnikov <makc>
Status: Closed FIXED    
Severity: Affects Only Me CC: makc
Priority: --- Flags: bugzilla: maintainer-feedback? (multimedia)
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
poudriere log
patch none

Description Yuri Victorovich freebsd_committer 2015-11-05 19:10:06 UTC
Created attachment 162817 [details]
Comment 1 Yuri Victorovich freebsd_committer 2015-11-05 19:15:56 UTC
Created attachment 162818 [details]
poudriere log

Summary of changes:
* Removed wxWidgets because wxWidgets are completely removed from the project (as per ChangeLog)
* Added NLS option due to gettext use

I ran poudriere build with and without QT5, both work. QT5=off is default.
Comment 2 Max Brazhnikov freebsd_committer 2015-11-07 09:44:02 UTC
I would prefer to enable QT% option by default, considering it is the only GUI now.
Comment 3 Yuri Victorovich freebsd_committer 2015-11-07 09:48:29 UTC
But most people will use it as a command line utility. Enabling QT by default would pull a ton of dependencies for just one simple window.
Comment 4 Max Brazhnikov freebsd_committer 2015-11-07 15:07:08 UTC
(In reply to yuri from comment #3)
> But most people will use it as a command line utility. Enabling QT by
> default would pull a ton of dependencies for just one simple window.

Firstly GUI option (WXGTK) was enabled by default before the project has switched to different toolkit. Secondly, for users which primarily use packages building the port without GUI option (if they don't want to install Qt 5) is less problematic than vice versa.

Btw, the NLS option is not respected. Would you like to spend more time on it? Alternatively I could revert it.
Comment 5 Yuri Victorovich freebsd_committer 2015-11-07 19:04:40 UTC
Ok, thanks, I will fix it.
Comment 6 Yuri Victorovich freebsd_committer 2015-11-08 02:21:18 UTC
Created attachment 162890 [details]

Updated patch:
* set QT5=on as a default
* fixed NLS option

poudriere build still passes.
Comment 7 commit-hook freebsd_committer 2015-11-18 10:47:59 UTC
A commit references this bug:

Author: makc
Date: Wed Nov 18 10:47:27 UTC 2015
New revision: 401860
URL: https://svnweb.freebsd.org/changeset/ports/401860

  - Update to 8.5.2.
  - WXGTK support has been removed upstream in favour of Qt
  - Amend BROKEN message
  - Enable verbose build when PACKAGE_BUILDING is set (instead of BATCH)
  - Decouple CURL option for online update checks from QT5
  - Add NLS option
  - Sort plist

  PR:		based on 204312
  Submitted by:	yuri@rawbw.com

Comment 8 Max Brazhnikov freebsd_committer 2015-11-18 11:11:17 UTC
Thanks, I've committed slightly modified version. For the future, you don't have to supply poudriere build log along with a patch. If committer reveals a problem during testing, then the attached build log proves nothing, and if the patch is ok, then the build log is not needed.
Comment 9 Yuri Victorovich freebsd_committer 2015-11-18 11:15:29 UTC
Well, people were asking for poudriere build before.
Comment 10 Max Brazhnikov freebsd_committer 2015-11-18 12:12:22 UTC
(In reply to yuri from comment #9)
> Well, people were asking for poudriere build before.
> Thanks.

It's a committer responsibility to properly check submitted patch. Of course this doesn't mean submitters shouldn't test it. Instead of providing build logs you could tell which OS versions/architectures the patch has been tested with poudriere.