Bug 204316

Summary: Account/Person in flag value (? <email>) cant modify flag status
Product: Services Reporter: Kubilay Kocak <koobs>
Component: Bug TrackerAssignee: Kubilay Kocak <koobs>
Status: Closed FIXED    
Severity: Affects Only Me CC: bugmeister, luca.pizzamiglio
Priority: --- Keywords: dogfood
Version: unspecified   
Hardware: Any   
OS: Any   
URL: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203607
See Also: https://bugzilla.mozilla.org/show_bug.cgi?id=1136039
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197656
Bug Depends on: 204211    
Bug Blocks:    

Description Kubilay Kocak freebsd_committer freebsd_triage 2015-11-06 03:17:53 UTC
It appears that the person (account) specified in the ? value of at least the attachment:maintainer-approval flag, cannot modify the flags value (eg: to +, to signal approval).

Eg:

maintainer-approval ? <foo@bar.tld>
Account <foo@bar.tld> cannot modify maintainer-approval flag value to +/-/null

I'm not sure if this is:

* Expected/Normal behaviour
* A bug in upstream bugzilla
* A permissions issue given our custom permission scheme
* A regression given the customisations we've made.

The expectation is that:

- an account with <email>
- should be able to modify the flag status
- for *any* flag where they are the current ? <email> value
- independent of their permissions (more precisely, without any special permissions, ie: everyone)
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2015-11-06 07:11:06 UTC
I reported that issue to upstream at the beginning of the year already. I thought to have that fixed in our setup, but probably did not do it (yet).
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-06 07:15:06 UTC
Thanks Marcus, are there any potential workarounds we can utilise in permissions (without opening up anything else) in the meantime, or is applying a patch the fix in the short term?
Comment 3 Marcus von Appen freebsd_committer freebsd_triage 2015-11-06 07:24:11 UTC
I thought to have it fixed properly already in our templates (see bug 197656), but it seems like there are still some issues with the fix. We should test this once more after the 5.0 update.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-09 04:35:20 UTC
I believe this is no longer an issue. At least, I haven't seen/received any reports of the issue.

I have to the contrary set the maintainer-approval ? flag myself and seen maintainers set its value later.