Bug 204381

Summary: multimedia/kodi: Add PULSEAUDIO option
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Martin Wilke <miwi>
Status: Closed FIXED    
Severity: Affects Only Me CC: mickael.maillot
Priority: --- Keywords: easy, needs-qa, patch, patch-ready
Version: LatestFlags: koobs: maintainer-feedback+
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch koobs: maintainer-approval+

Description Yuri Victorovich freebsd_committer freebsd_triage 2015-11-09 00:49:28 UTC
Created attachment 162912 [details]
patch

Since in my experience many FreeBSD desktops run PulseAudio, it is good to have it enabled.

Testing I did: ran it and saw it playing through the PulseAudio, when before it used OSS.
Comment 1 mickael.maillot 2015-11-25 16:40:27 UTC
Looks good to me, if you have tested it on real hardware it's perfect.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-27 02:50:20 UTC
@Yuri Confirmation this passes QA would be great. 

Also, should/would we like this to be merged to the quarterly branch? It's a good candidate
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2015-11-28 16:26:27 UTC
I verified, PULSEAUDIO works on real system.
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2015-12-05 08:57:39 UTC
Take.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-12-08 16:49:07 UTC
A commit references this bug:

Author: miwi
Date: Tue Dec  8 16:48:23 UTC 2015
New revision: 403296
URL: https://svnweb.freebsd.org/changeset/ports/403296

Log:
  - Add PULSEAUDIO knob

  PR:		204381
  Submitted by:    yuri@rawbw.com
  Approved by:	mat (mentor), maintainer timeout 3 weeks+
  Differential Revision:	https://reviews.freebsd.org/D4432

Changes:
  head/multimedia/kodi/Makefile