Bug 204421

Summary: graphics/pngcrush: Update to 1.7.87
Product: Ports & Packages Reporter: Anton Saietskii <vsasjason>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Only Me CC: koobs, pi, vsasjason
Priority: --- Keywords: easy, patch, patch-ready
Version: LatestFlags: koobs: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch for update
vsasjason: maintainer-approval+
portupgrade log
none
make: stage & qa log
none
make: stage & qa log none

Description Anton Saietskii 2015-11-10 07:52:45 UTC
Created attachment 162950 [details]
patch for update

*  Fixed a double-free bug. There was a "free" of the sPLT chunk structure
    in pngcrush and then again in png.c (Bug report by Brian Carpenter).
*  Added common-law trademark notice and export control information.
*  Rearranged some paragraphs in the comments at the beginning of pngcrush.c
*  Increased some buffer sizes in an attempt  to prevent possible overflows.
Comment 1 Anton Saietskii 2015-11-10 07:53:21 UTC
Created attachment 162951 [details]
portupgrade log
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-10 07:56:55 UTC
Thanks Anton.

Can you please confirm this passes QA please (portlint/poudriere)

Unfortunately portupgrade/plain installation doesn't run the requisite checks.
Comment 3 Anton Saietskii 2015-11-10 08:12:03 UTC
(In reply to Kubilay Kocak from comment #2)
Unfortunately, I don't have access to any poudriere instance right now, and RedPorts is down. :-(
I can try to install Poudriere somewhere in the next few days if you wish.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-10 08:14:10 UTC
@Anton,

Thanks for the quick response. In the meantime, you may include (as an attachment), the output of:

make stage && make check-plist && make stage-qa && make package
Comment 5 Anton Saietskii 2015-11-10 08:23:52 UTC
Created attachment 162952 [details]
make: stage & qa log

Tested on FreeBSD 10.1-RELEASE-p12 amd64.
Comment 6 Anton Saietskii 2015-11-10 08:25:38 UTC
Created attachment 162953 [details]
make: stage & qa log

Oops, incorrect output redirection, revised version
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2015-11-20 19:48:14 UTC
test-builds done on 11-cur, 10.2a+i, 9.3a, all fine.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-11-20 19:50:36 UTC
A commit references this bug:

Author: pi
Date: Fri Nov 20 19:50:01 UTC 2015
New revision: 402097
URL: https://svnweb.freebsd.org/changeset/ports/402097

Log:
  graphics/pngcrush: 1.7.86 -> 1.7.87

  - Fixed a double-free bug. There was a "free" of the sPLT chunk structure
    in pngcrush and then again in png.c (Bug report by Brian Carpenter).
  - Added common-law trademark notice and export control information.
  - Rearranged some paragraphs in the comments at the beginning of pngcrush.c
  - Increased some buffer sizes in an attempt  to prevent possible overflows.

  PR:		204421
  Submitted by:	Anton Sayetsky <vsasjason@gmail.com> (maintainer)

Changes:
  head/graphics/pngcrush/Makefile
  head/graphics/pngcrush/distinfo
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2015-11-20 19:50:50 UTC
Committed, thanks.