Bug 204600
| Summary: | security/libgcrypt: Readd missing patch | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Carlos J Puga Medina <cjpm> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Martin Wilke <miwi> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | junovitch, koobs, miwi, pi | ||||||||||
| Priority: | --- | Keywords: | easy, patch, patch-ready, regression | ||||||||||
| Version: | Latest | Flags: | koobs:
merge-quarterly?
|
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 204323, 204399 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Carlos J Puga Medina
2015-11-16 15:20:12 UTC
Carlos can you please confirm this passes QA Also: Should this go upstream? Is there a root cause fix that can be made in KeePass? (In reply to Kubilay Kocak from comment #1) Testing@work via poudriere. As to whether this patch should go upstream. The answer is yes, it should go upstream. Currently I'm not sure if exists a fix for KeePassX :( Created attachment 163211 [details]
poudriere testport on 93x32
Created attachment 163212 [details]
poudriere testport on 93x64
Created attachment 163213 [details]
poudriere testport on 10x32
% portlint -ac WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 1 warning found. Assign PR. Carlos, This is a tricky one with restoring previous files. The process is similar to re-adding a deleted port [1]. We do this for a clean SVN history and you will need to copy the patch from the revision before it was deleted. For example, svn cp --parents 'svn+ssh://cpm@repo.FreeBSD.org/ports/head/security/libgcrypt/files/patch-cipher-Makefile.in@400318' files/patch-cipher-Makefile.in The `svn status` should reflect: M Makefile A files A + files/patch-cipher-Makefile.in Please update your QA and provide a commit message when you have done so. Additionally, please provide a reference to the upstream report of the issue so that there is visibility on it being reported. [1] https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-resurrect A commit references this bug: Author: pi Date: Sun Nov 22 17:33:05 UTC 2015 New revision: 402237 URL: https://svnweb.freebsd.org/changeset/ports/402237 Log: security/libgcrypt: Re-add missing patch - This patch was removed when updating to 1.6.4, so the patch needs to be put back in order to solve the bug 204399. PR: 204600 Submitted by: Carlos J. Puga Medina <cpm@fbsd.es> (maintainer) Changes: head/security/libgcrypt/Makefile head/security/libgcrypt/files/ head/security/libgcrypt/files/patch-cipher-Makefile.in Carlos, please try to push the fix upstream. (In reply to Kurt Jaeger from comment #10) Here it is: https://lists.gnupg.org/pipermail/gcrypt-devel/2015-November/003632.html Done in rev: 402237 Done in rev: 402237 Assign to committer that resolved, Re-open for MFH |
