Bug 204615
| Summary: | bsd.port.mk: USE_LINUX as build-only dependency | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> |
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | portmaster, tijl |
| Priority: | --- | Keywords: | needs-patch |
| Version: | Latest | Flags: | koobs:
merge-quarterly?
|
| Hardware: | Any | ||
| OS: | Any | ||
| Bug Depends on: | 211645 | ||
| Bug Blocks: | |||
Am I allowed to add a +1 here? If so, consider this my vote to add this feature. Thanks, Jan! (In reply to Chris Hutchinson from comment #1) Don't ask for permission when it comes to communication :) Feedback is important, and we don't have the 'vote' feature turned on. Ideally, the feedback is more than just a "+1", but also explains/confirms/reiterates the value/benefit to you :) CC'ing tijl as he works on USES=linux and may (or not) want to tackle :build argument similar to USES=python:build. Can you check that the changes made to devel/fb-adb in bug 211645 are correct? Fixed in ports r421387. |
USE_LINUX assumes anything built by a linux toolchain targets linuxulator. In some cases a port may want to build either for native (e.g. using proprietary toolchain) or for unsupported ABI (e.g. FreeBSD<->device bridge). To fix maybe extend the syntax to allow arguments (similar to USES) e.g., USE_LINUX= yes:build USE_LINUX= c6_64:build to avoid hacks like in devel/fb-adb: BUILD_DEPENDS= ${LINUX_BASE_PORT} USE_LINUX= yes .include <bsd.port.mk> .if defined(.PARSEDIR) RUN_DEPENDS:= ${RUN_DEPENDS:N${LINUX_BASE_PORT}} .else RUN_DEPENDS:= ${RUN_DEPENDS:N*linux_base*} .endif