Bug 204653
| Summary: | www/node: Update to 5.2.0 (After copy www/node -> www/node4) | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | adamw, koobs, linpct, rwestlun | ||||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 163277 [details]
poudriere log
Hi, my opinion is let www/node keep 4.x LTS and www/node-devel for node-stable. Because node.js version change very often, so I think its stable version will be tagged with 5.x, 6.x, 7.x soon. Please send another patch for update www/node to 4.2.2 and www/node-devel to 5.1.0, or just let me handle it. Thanks. Created attachment 163280 [details]
patch
Created attachment 163281 [details]
patch for www/node-devel
Submitting patches as you suggested.
And they both pass poudriere build. (In reply to linpct from comment #2) I'm not sure -devel is the right place for a future/current stable release (or branch). How about node5 ? My understanding is that NodeJS is overall quite unstable, this is why the maintainer wants to kind-of hold it back. There is no reason to create node5, because version 5 is just a point in its evolution. Not much different. www/node should always be the current stable version. www/node-devel should be a devel version. It should never be the stable version. A LTS release should be www/node4. People should always expect that www/node is the current version, www/node4 is fixed at 4.x, and -devel is experimental. Please do no invent new meanings for directory names. It's just going to confuse people. In such case, just use my original (labeled obsolete) patch for www/node. Hi, I agree with Adam's comment. And approve the patch for node v5.1.0. Please (1) copy and create a new port named www/node4 (2) let www/node be v5.1.0 (3) let www/node-devel keep its version (4) review if we also need to keep www/node* (010,012) Thanks. @Yuri, comment 10 is unclear: * "(3) let www/node-devel keep its version", but * attachment 163281 [details] updates to 5.1.0 And: * attachment 163280 [details] updates to 4.2.2, but * This issue summary is 'update www/node to 5.1.0 Goal: There should be no additional work to do for a committer (other than copying www/node -> www/node4) if that's what you would like. Please obsolete patches as necessary, so that @Linpct can approve 'attachment ids' and set maintainer-approval on them as necessary. Update or re-run QA process if necessary as well Also, an updated patch is needed to match the changes that need to take place in www/node, since www/node-devel and www/node4 are not changing in this issue. Ping @Yuri re comment 11 and comment 12 Created attachment 164146 [details]
update node to 5.2.0
In the mean tine, node 5.2.0 was released. I've attached a patch to update www/node to 5.2.0. It passes testing.
For what it's worth as someone who uses node every day, I doubt www/node010 and www/node012 are still useful.
Maintainer approved. 1. Remove node010, but keep node012 for a while. 2. Let www/node be 5.2.0, www/node-devel keep its version(5.0.0) and create www/node4 be 4.2.3 Thanks. (In reply to linpct from comment #15) We still need a patch for 4.2.3 Created attachment 164218 [details]
patch to create node4 at 4.2.3
Patch to create node4 at version 4.2.3 is attached.
(In reply to Randy Westlund from comment #17) Thanks Randy! A commit references this bug: Author: koobs Date: Tue Dec 15 04:40:22 UTC 2015 New revision: 403756 URL: https://svnweb.freebsd.org/changeset/ports/403756 Log: www/node: Update to 5.2.0, Create www/node4, Update to 4.2.3 www/node: * Update PORTVERSION and distinfo checksum (5.2.0) [1] * Add CONFLICTS to www/node4 www/node4: * Create www/node4 port for LTS users * Update www/node4 to 4.2.3 [2] * Add CONFLICTS to www/node * Add UPDATING entry for users wishing to remain on LTS (4.x) Based on: PR: 204653 [1][2] Submitted by: Randy Westlund <rwestlun gmail com> [1][2] Approved by: maintainer <linpct gmail com> Changes: head/UPDATING head/www/Makefile head/www/node/Makefile head/www/node/distinfo head/www/node4/ head/www/node4/Makefile head/www/node4/distinfo Committed attachment 164146 [details] and attachment 164218 [details] with additions (CONFLICTS + UPDATING). Thank you Randy! (In reply to commit-hook from comment #19) @Linpct, per your comment 15, can you please create new and separate issues for: * Add DEPRECATED/EXPIRES for node010 (EXPIRES=3 months from now) and node012 (EXPIRES=whenever you want) Thanks |
Created attachment 163276 [details] patch