Bug 204667
| Summary: | devel/p5-Data-Serializer: Remove forced optional dependencies | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||
| Component: | Individual Port(s) | Assignee: | Frederic Culot <culot> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Keywords: | easy, patch, patch-ready | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(culot) koobs: merge-quarterly? |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: culot Date: Thu Nov 19 11:27:46 UTC 2015 New revision: 401929 URL: https://svnweb.freebsd.org/changeset/ports/401929 Log: - Remove unneeded dependencies [1] - Add NO_ARCH PR: 204667 [1] Submitted by: adamw@ Changes: head/devel/p5-Data-Serializer/Makefile Thanks Adam for your PR! Is there value of adding OPTIONS in for these, OPTIONS_DEFAULT or otherwise? Also, should this be merged (MFH) to quarterly? (In reply to Kubilay Kocak from comment #3) Data::Serializer works with 16 different serializer backends, and with any encryption method that Crypt::CBC supports. The port works out of the box with no extra dependencies installed, and the presence of any of the extra backends at build/install time doesn't influence the generated package in anyway. So, I'm not sure that I see what the end-result benefit would be. That's my $0.02. I would tend to agree with Adam here, I am not sure using options would add any benefits to the port. With regards to the merge, I do not consider the changes to be critical enough to require a MFH. So if it is acceptable for both of you I would close this PR. (In reply to Frederic Culot from comment #5) I agree with you, culot. A MFH could be confusing for people when dependencies change in a port that worked fine before. |
Created attachment 163314 [details] reduce dependencies Right now, devel/p5-Data-Serializer has optional dependencies listed as hard dependencies. Neither Crypt::CBC nor YAML are required for Data::Serializer, so it'd be nice not to have them force-installed if I don't need them. Also, USE_PERL5=modbuild brings in a couple of dependencies, but p5-Data-Serializer comes with a Makefile.PL so USE_PERL5=configure is sufficient. The attached patch reduces the number of mandatory dependencies from 4 to 0, and it still builds, installs, and tests without problem.