Bug 204687
| Summary: | lint should not lint files I haven't changed | ||
|---|---|---|---|
| Product: | Services | Reporter: | John Baldwin <jhb> |
| Component: | Code Review | Assignee: | Phabric Admin <phabric-admin> |
| Status: | Closed Not A Bug | ||
| Severity: | Affects Only Me | ||
| Priority: | --- | ||
| Version: | unspecified | ||
| Hardware: | Any | ||
| OS: | Any | ||
Bah, this was not arcanist's fault. The 'master' on the clone I was working with was older than the base of the tree I was updating a diff from so it was working with a huge diff (and thus triggered many false positives). Glad to hear it. Sorry about the delay in replying. I've been trying to repro :\ |
I just tried to update D3341 from a git checkout on zoo.freebsd.org. I had to say no to 10+ spelling mistakes (mostly in the linuxkpi bits) that were in code I hadn't changed. This was not helpful. Furthermore, arc failed to actually upload a diff since linting threw an exception since it couldn't find PEP8: Exception Some linters failed: - ArcanistMissingLinterException: Unable to locate binary "pep8" to run linter ArcanistPEP8Linter. You may need to install the binary, or adjust your linter configuration. TO INSTALL: Install PEP8 using `easy_install pep8`. (Run with `--trace` for a full exception trace.) 49 From arc's help it seems this isn't the default (since there is a --lintall that doesn't claim to be on by default). If lint stays broken developers will just use --nolint to turn it off (which is what I did to workaround this rediculousness)