Bug 204754
| Summary: | audio/festival: Update to 2.4 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Anonymized Account <no-reply> | ||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | freebsd-2024, mi, pi | ||||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(freebsd-2024) |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 163439 [details]
audio/festival: portlint -AC
Created attachment 163440 [details]
audio/festival: poudriere output
Test-builds on 11a, 10.2a+i, 9.3a are fine. Please try building without those (in groups): 1. files/patch-debian-bug-667377 <-- also without last 2 chunks 2. files/patch-speech__tools_include_EST__Ngrammar.h files/patch-speech__tools_include_EST__String.h 3. files/patch-speech__tools_config_compilers_gcc__defaults.mak I can do it myself, but not sooner than tomorrow's evening. If the test (a.k.a. post-build) target succeeds everywhere, please, go ahead and commit the upgrade. Thank you! The problem is those patches may be unnecessary and cause problems in the future. I'm testbuilding without the four patch-files as requested. If it succeeds, I'll commit this. Test-builds on 11a, 10.2a+i, 9.3a with the four patches removed are fine, too. A commit references this bug: Author: pi Date: Sun Nov 29 20:09:50 UTC 2015 New revision: 402619 URL: https://svnweb.freebsd.org/changeset/ports/402619 Log: audio/festival: 2.1 -> 2.4 - Updated HTS and CG engines - Support for newer compilers - Bug fixes galore. PR: 204754 Submitted by: Michael Danilov <mike.d.ft402@gmail.com> Approved by: mi (maintainer) Changes: head/audio/festival/Makefile head/audio/festival/distinfo head/audio/festival/files/patch-debian-bug-667377 head/audio/festival/files/patch-festival_src_modules_hts_engine_HTS_misc.c head/audio/festival/files/patch-voxware head/audio/festival/pkg-plist Committed, thanks. |
Created attachment 163438 [details] audio/festival In some patches there are chunks left that still differ from new code -- need someone with knowledge to look at them: files/patch-debian-bug-667377 Original version of these were downloaded as distfiles: files/patch-speech__tools_config_compilers_gcc__defaults.mak files/patch-speech__tools_include_EST__Ngrammar.h files/patch-speech__tools_include_EST__String.h In files/patch-voxware "char *audiodevice;" has already been replaced with "const char *audiodevice;" where the old patch did. But there is one more location where "char *audiodevice;" is untouched -- I made the patch replace there instead. files/patch-festival_src_modules_hts_engine_HTS_misc.c is a dirty hack: there is no proper detection of FreeBSD in the file.