Bug 204765

Summary: net/tshark fails to build since 2.0
Product: Ports & Packages Reporter: Sergey Akhmatov <sergey>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Only Me CC: elofu17
Priority: --- Flags: bugzilla: maintainer-feedback? (marcus)
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
poudriere build log none

Description Sergey Akhmatov 2015-11-23 10:58:52 UTC
Created attachment 163455 [details]
poudriere build log

net/tshark does not build since version 2.0

gmake[6]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0/doc'
gmake[5]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0/doc'
gmake[4]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
gmake[3]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
gmake[2]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
/bin/mv /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk  /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark
mv: /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk: No such file or directory
*** Error code 1

poudriere log attached.
Comment 1 elofu17 2015-11-23 14:41:05 UTC
Same error for me.

gmake[1]: Leaving directory '/wrkdirs/usr/ports/net/tshark/work/wireshark-2.0.0'
/bin/mv /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk  /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark
mv: /wrkdirs/usr/ports/net/tshark/work/stage/usr/local/bin/tshark-gtk: No such file or directory
*** Error code 1

make: stopped in /usr/ports/net/tshark
====>> Cleaning up wrkdir
===>  Cleaning for tshark-2.0.0
build of net/tshark ended at Mon Nov 23 11:58:10 CET 2015
build time: 00:10:09
!!! build failure encountered !!!
Comment 2 elofu17 2015-11-23 14:58:49 UTC
If it has any relevance (I see "gtk" in the filename), I've disabled X11 in my make.conf :

Comment 3 commit-hook freebsd_committer 2015-11-23 15:02:39 UTC
A commit references this bug:

Author: marcus
Date: Mon Nov 23 15:01:42 UTC 2015
New revision: 402278
URL: https://svnweb.freebsd.org/changeset/ports/402278

  Be a bit more selective with the port-install to fix tshark.

  PR:		204765

Comment 4 Joe Marcus Clarke freebsd_committer 2015-11-23 15:03:31 UTC
Fixed.  I made this change-last minute after I did the tshark test.  Forgot that QT5 off meant the no GUI case, too.
Comment 5 Sergey Akhmatov 2015-11-23 15:40:22 UTC
Build succeedes, make install or make package fails:

===>  Building package for tshark-2.0.0
pkg-static: Unable to access file /usr/ports/net/tshark/work/stage/usr/local/%%GUI_GTK%%share/applications/wireshark-gtk.desktop: No such file or directory
*** Error code 1

Seems like problem with plist
GUI_GTK remains unset in case neither of GTK2, GTK3 and QT5 is selected
Comment 6 Sergey Akhmatov 2015-11-23 15:49:15 UTC
Patch fixes things for me:

--- Makefile    (revision 402278)
+++ Makefile    (working copy)
@@ -128,6 +128,7 @@
 CONFIGURE_ARGS+=       --disable-wireshark
 PLIST_SUB+=            GUI="@comment "
+PLIST_SUB+=            GUI_GTK="@comment "
 USES+=                 desktop-file-utils shared-mime-info
 INSTALLS_ICONS=                yes
Comment 7 Joe Marcus Clarke freebsd_committer 2015-11-23 15:55:56 UTC
Sorry, meant to add this macro.