Bug 204810

Summary: [PATCH] x11-toolkits/mygui: Update to MyGUI 3.2.2
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: patch
Priority: --- Flags: bugzilla: maintainer-feedback? (amdmi3)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
mygui.diff
none
Poudriere log FreeBSD 10.2/amd64
none
mygui.diff
none
mygui.diff
none
Poudriere log FreeBSD 10.2/amd64 none

Description Tobias Kortkamp freebsd_committer freebsd_triage 2015-11-25 16:07:34 UTC 
Created attachment 163527 [details]
mygui.diff

See attached patch.  This is in preparation of an OpenMW port (http://openmw.org).  I've removed the Ogre3D dependency because it's not required by OpenMW anymore and MyGUI seems to not be used by any current port.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2015-11-25 16:08:47 UTC 
Created attachment 163528 [details]
Poudriere log FreeBSD 10.2/amd64
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-25 18:43:45 UTC 
Nice, I've wanted to port openmw for a long time but never really got to do it. I've added mygui port solely for this purpose as far as I remember. Looking at the update now.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2015-11-26 19:11:25 UTC 
Created attachment 163556 [details]
mygui.diff

I completely overlooked the portlint warnings and errors on my patch before submitting this PR...  Sorry.  I fixed them all now.

In other news OpenMW builds and runs on FreeBSD now :) See https://github.com/t6/wip-ports/tree/master/games/openmw and https://imgur.com/vrAi2t8
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-12-01 12:53:13 UTC 
Why'd you need LDFLAGS?
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2015-12-01 13:26:55 UTC 
Created attachment 163703 [details]
mygui.diff

I don't remember, it probably is just a copy/paste error.  I've removed it and the port still compiles.  dos2unix seems to be unnecessary now, too. See https://github.com/MyGUI/mygui/pull/19
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2015-12-01 13:28:25 UTC 
Created attachment 163704 [details]
Poudriere log FreeBSD 10.2/amd64
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2015-12-01 13:53:40 UTC 
Committed with minor changes, thank you!

Changes:
- Use DISTVERSIONPREFIX instead of GH_TAGNAME
- Add LICENSE_FILE
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-12-01 13:53:49 UTC 
A commit references this bug:

Author: amdmi3
Date: Tue Dec  1 13:53:45 UTC 2015
New revision: 402736
URL: https://svnweb.freebsd.org/changeset/ports/402736

Log:
  - Update to 3.2.2

  PR:		204810
  Submitted by:	tobias.kortkamp@gmail.com

Changes:
  head/x11-toolkits/mygui/Makefile
  head/x11-toolkits/mygui/distinfo
  head/x11-toolkits/mygui/files/
  head/x11-toolkits/mygui/pkg-plist