Bug 204842
| Summary: | editors/emacs-devel: Update to latest (emacs-25 branch) revision | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Joseph Mingrone <jrm> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Ashish SHUKLA <ashish> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Some People | Keywords: | patch, patch-ready | ||||||||||
| Priority: | --- | Flags: | ashish:
maintainer-feedback+
|
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 163571 [details]
poudriere testport log
Created attachment 163592 [details]
editors/emacs-devel: patch to update to latest git revision (emacs-25 branch)
I fixed a minor pkg-plist issue in the last patch and also did svn remove for deleted files this time.
Created attachment 163593 [details]
poudriere testport output (10amd64)
Hi Joseph, The changes look great to me, esp. the switching to GitHub mirror. I've tested it on my 10.2-RELEASE host, and seemed to have no issues. I'm testing on other platforms, and will provide feedback, and/or commit it. Thanks! Ashish Hi Ashish, Great! Let me know if there is anything I can help test. Joseph A commit references this bug: Author: ashish Date: Mon Nov 30 00:25:00 UTC 2015 New revision: 402637 URL: https://svnweb.freebsd.org/changeset/ports/402637 Log: - Update to git revision af40b76 - Switch to GitHub for MASTER_SITES - Remove USE_AUTOTOOLS, and move it to USES instead - Cosmetic changes to Makefile, and pkg-plist - Remove pkg-install/pkg-deinstall scripts, not needed anymore PR: 204842 Submitted by: Joseph Mingrone <jrm at ftfl.ca> Changes: head/editors/emacs-devel/Makefile head/editors/emacs-devel/distinfo head/editors/emacs-devel/files/pkg-install.in head/editors/emacs-devel/pkg-deinstall head/editors/emacs-devel/pkg-plist Thanks so much. I've committed the port with some minor changes, as discussed on IRC. Ashish |
Created attachment 163570 [details] patch to update editors/emacs-devel to latest git revision on emacs-25 branch Since the Emacs repository is now mirrored on GitHub, I thought it would be easier to pull from there. This way, when the port needs to be updated, it might be as simple as updating two or three lines (e.g., GH_TAGNAME, EMACS_REV) in the Makefile. I also tried to simplify things: pkginstall.in and pkg-deinstall are no longer necessary and things are synced as much as possible with editors/emacs. There are some cosmetic changes: I fixed some misalignments and sorted lists alphabetically. Since these sort of cosmetic changes can be subjective, just let me know if they aren't welcomed and I can submit a new patch without them.