Bug 205017

Summary: [PATCH] security/fastd: Disable mpclmul module on FreeBSD 9.
Product: Ports & Packages Reporter: Raphael Kubo da Costa <rakuco>
Component: Individual Port(s)Assignee: Raphael Kubo da Costa <rakuco>
Status: Closed FIXED    
Severity: Affects Only Me CC: crest, crest_maintainer
Priority: --- Keywords: patch
Version: LatestFlags: crest: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Proposed patch
none
Patch v2 none

Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 14:31:45 UTC
Created attachment 163842 [details]
Proposed patch

The attached patch makes the port build on FreeBSD 9, which has failed ever since it was added to the tree.

From the fallout logs:
  CMake Error at src/crypto/mac/ghash/pclmulqdq/CMakeLists.txt:9 (message):
    WITH_MAC_GHASH_PCLMULQDQ enabled, but there is no compiler support for
    -mpclmul

This happens because GCC 4.2.1 in base (the default compiler) does not support the -mpcmul option.

Fix it by disabling the module when on FreeBSD < 10 (i.e. when base GCC is the default compiler).
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 15:10:23 UTC
Created attachment 163845 [details]
Patch v2

Patch v2, with CMAKE_ARGS+= instead of CMAKE_ARGS=.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-04 15:27:32 UTC
For some reason my commit was only mentioned in bug 205018. This was landed in https://svnweb.freebsd.org/changeset/ports/402993