Bug 205018
| Summary: | [PATCH] security/fastd-devel: Disable mpclmul module on FreeBSD 9. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Raphael Kubo da Costa <rakuco> | ||||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | crest, crest_maintainer | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | crest:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Please use += instead of = to concatenate the cmake arguments. Created attachment 163844 [details]
Patch v2
Argh, stupid bsd.pre.port.mk. Patch v2 attached.
The non-devel version needs the same patch as well. Yeah, I updated it when I fixed this one. (in bug 205017) A commit references this bug: Author: rakuco Date: Fri Dec 4 15:22:35 UTC 2015 New revision: 402993 URL: https://svnweb.freebsd.org/changeset/ports/402993 Log: fastd, fastd-devel: Disable mpclmul module on FreeBSD 9. This fixes the build on 9, which has failed ever since it was added to the tree. From the fallout logs: CMake Error at src/crypto/mac/ghash/pclmulqdq/CMakeLists.txt:9 (message): WITH_MAC_GHASH_PCLMULQDQ enabled, but there is no compiler support for -mpclmul This happens because GCC 4.2.1 in base (the default compiler) does not support the -mpcmul option. Fix it by disabling the module when on FreeBSD < 10 (i.e. when base GCC is the default compiler). PR 205017 PR: 205018 Approved by: Jan Bramkamp <crest_maintainer@rlwinm.de> (maintainer) Changes: head/security/fastd/Makefile head/security/fastd-devel/Makefile |
Created attachment 163843 [details] Proposed patch The attached patch makes the port build on FreeBSD 9, which has failed ever since it was added to the tree. From the fallout logs: CMake Error at src/crypto/mac/ghash/pclmulqdq/CMakeLists.txt:9 (message): WITH_MAC_GHASH_PCLMULQDQ enabled, but there is no compiler support for -mpclmul This happens because GCC 4.2.1 in base (the default compiler) does not support the -mpcmul option. Fix it by disabling the module when on FreeBSD < 10 (i.e. when base GCC is the default compiler).