Bug 205036
| Summary: | [PATCH][build] remove redundant check of the DEBUG_FLAGS in bsd.prog.mk | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Alexander Kuleshov <kuleshovmail> | ||||
| Component: | misc | Assignee: | Mateusz Piotrowski <0mp> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Only Me | CC: | 0mp, cuxomihapu, jokebos, kuleshovmail, sjg, vocok, wuninaz | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | CURRENT | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM But if MK_CTF is "no", then we would not set STRIP. I am not sure if that's correct. I'll close the PR for now. Please reopen it if I misunderstood the patch. Cheers! Of course I read it incorrectly. Sorry about that. I'm reopening this PR. I don't think it is necessary to commit this style patch. The current version is readable. At the same time, the proposed change introduces a potentially confusing else statement, which has to be clarified with a comment. |
Created attachment 163866 [details] Remove redundant check of the DEBUG_FLAGS Hello, This patch removes redundant check of the DEBUG_FLAGS in the bsd.prog.mk. We already check it above in the same file, so we no need to check it again.