Bug 205060

Summary: [NEW PORT] security/py-pynacl: Python binding to the Networking and Cryptography library
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Martin Wilke <miwi>
Status: Closed FIXED    
Severity: Affects Only Me CC: koobs, miwi, python, yuri
Priority: --- Keywords: feature, needs-patch, needs-qa, patch
Version: LatestFlags: koobs: maintainer-feedback? (yuri)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
shar archive none

Description Yuri Victorovich freebsd_committer freebsd_triage 2015-12-06 13:39:24 UTC
Created attachment 163898 [details]
shar archive

Passes poudriere build.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-07 08:14:24 UTC
@Yuri,

* post-install is *very* incorrectly stripping every *.so in PREFIX/lib. Only strip the *.so's produced by this software. Please update any other attachments in any other issues you have open if they do the same.

Could you also:

* Lowercase PORTNAME
* Remove "PyNaCl is a " from the prefix of COMMENT
* You probably want LIB_DEPENDS for libnacl not BUILD_DEPENDS
* The WWW url, specified in setup.py:homepage is: https://github.com/pyca/pynacl/, please update pkg-descr WWW: to match
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-12-07 09:20:57 UTC
There is only one .so file in the stage directory, so this wouldn't make any difference. -)
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-07 09:22:49 UTC
(In reply to yuri from comment #2)

Explicit > implicit, and a port only touching its own files is a major compliance item.

Please update that post-install code here and anywhere else it exists
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2015-12-27 07:45:48 UTC
In the perfect world USES=python should have an option 'strip', and it should do about the same what this port does:

> post-install:
>	@${FIND} ${STAGEDIR}${PREFIX}/lib -name "*.so" -and -exec ${STRIP_CMD} {} \;

I will submit a patch for Mk/Uses/python.mk separately.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-01-04 07:55:57 UTC
A commit references this bug:

Author: miwi
Date: Mon Jan  4 07:55:32 UTC 2016
New revision: 405221
URL: https://svnweb.freebsd.org/changeset/ports/405221

Log:
  PyNaCl is a Python binding to the Networking and Cryptography library, a crypto
  library with the stated goal of improving usability, security and speed.

  WWW: https://pypi.python.org/pypi/PyNaCl/

  PR:		205060
  Submitted by:	Yuri Victorovich <yuri@rawbw.com>

Changes:
  head/security/Makefile
  head/security/py-pynacl/
  head/security/py-pynacl/Makefile
  head/security/py-pynacl/distinfo
  head/security/py-pynacl/files/
  head/security/py-pynacl/files/patch-setup.py
  head/security/py-pynacl/pkg-descr