Bug 205082

Summary: [MAINTAINER] graphics/qgis: Update to 2.12.2
Product: Ports & Packages Reporter: Rainer Hurling <rhurlin>
Component: Individual Port(s)Assignee: Martin Wilke <miwi>
Status: Closed FIXED    
Severity: Affects Many People CC: miwi, rhurlin
Priority: --- Keywords: easy, patch, patch-ready
Version: LatestFlags: rhurlin: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to update graphics/qgis to 2.12.1
vlad-fbsd: maintainer-approval+
patch to update to 2.12.1, with converted options
rhurlin: maintainer-approval+
patch to 2.12.2, with new PostGIS dependency
rhurlin: maintainer-approval+
patch to update to 2.12.2, with execinfo switch rhurlin: maintainer-approval+

Description Rainer Hurling freebsd_committer freebsd_triage 2015-12-07 10:23:11 UTC
Created attachment 163932 [details]
patch to update graphics/qgis to 2.12.1

Only some minor bugfixes and enhancements.

Tested with Poudriere (HEAD, 10.2 and 9.3 all amd64; 9.3 i386).

'portlint -AC' gives no errors.
Comment 1 VK 2015-12-07 11:14:45 UTC
Thanks for the submission.

Just a tiny note, the maintainer-approval should go on the patch rather than doing the maintainer-feedback since this is both a request to update and the solution in one go, as you're the maintainer and so there never was a maintainer feedback request to begin with. I'm gonna go ahead and add the patch to the flag this time.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2015-12-11 05:51:57 UTC
Hi Rainer,

While we are updating this port can you please also convert the options to the new way. 

Thanks in advance.
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2015-12-11 19:50:14 UTC
(In reply to Martin Wilke from comment #2)
Hi Martin,

Thanks for the suggestion. My second patch replaces the first one and should contain the converted options.

For some time now, it seems not be necessary any more to forbid option GRASS under FreeBSD 9.x and lower. I think this is because of the GRASS plugin, which is not an extra port, but integrated in graphics/gdal from version 2.x on :) So I removed the differentiation for the GRASS option.

With newer options there is a need to use plist_subs named like the options itself. So I renamed them in Makefile and in pkg-plist.

I wasn't able to use ${OPSYS} and ${OSVERSION} without including <bsd.port.options.mk>. Could you please have a look at it?


Poudriere and 'portlint -AC' both seems fine with the changes.
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2015-12-11 19:51:25 UTC
Created attachment 164124 [details]
patch to update to 2.12.1, with converted options
Comment 5 Rainer Hurling freebsd_committer freebsd_triage 2015-12-20 16:50:09 UTC
Created attachment 164426 [details]
patch to 2.12.2, with new PostGIS dependency

In the meantime, there was another update of QGIS to 2.12.2.

This patch is mainly the same, but changes one dependency from PostgreSQL to PostGIS. PostgreSQL is not very useful within QGIS without PostGIS extensions.
Comment 6 Rainer Hurling freebsd_committer freebsd_triage 2016-01-05 12:12:47 UTC
Created attachment 165101 [details]
patch to update to 2.12.2, with execinfo switch

Like Pawel@ suggested in bug #205702, the switch to USES=execinfo is now integrated into my last patch with the new PostGIS dependency.

After committing, please also close bug #205702, thanks.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-01-10 05:38:29 UTC
A commit references this bug:

Author: miwi
Date: Sun Jan 10 05:37:38 UTC 2016
New revision: 405663
URL: https://svnweb.freebsd.org/changeset/ports/405663

Log:
  - Update to 2.12.2
  - Switch to options helper
  - Switch to USES=execinfo [1]

  PR:		205082 205702 [1]
  Submitted by:	maintainer, pawel [1]

Changes:
  head/graphics/qgis/Makefile
  head/graphics/qgis/distinfo
  head/graphics/qgis/pkg-plist