Bug 205142
| Summary: | www/photo_gallery: Whitespace fix, modernize | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | bob | ||||
| Priority: | --- | Keywords: | easy, patch, patch-ready | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(bob) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Reporter is committer, assign accordingly @Dmitry, these are all blanket changes with implicit approval no? (In reply to Kubilay Kocak from comment #2) > @Dmitry, these are all blanket changes with implicit approval no? Regardless of whether there's blanket approval there are changes I'd like to be reviewed by maintainer first. A commit references this bug: Author: amdmi3 Date: Fri Jan 8 13:48:59 UTC 2016 New revision: 405547 URL: https://svnweb.freebsd.org/changeset/ports/405547 Log: - Fix extra whitespace - Switch to COPYTREE_SHARE - Add NO_ARCH - Modernize plist PR: 205142 Submitted by: amdmi3 Approved by: maintainer timeout (bob@bomar.us, 1 month) Changes: head/www/photo_gallery/Makefile head/www/photo_gallery/pkg-plist |
Created attachment 163993 [details] Patch - Fix extra whitespace - Switch to COPYTREE_SHARE - Add NO_ARCH - Don't set owner/group: this does open any files for writing, so it doesn't need any write permissions - Drop @dirrm For convenience, here's the same diff but with whitespace changes ignored: --- Index: Makefile =================================================================== --- Makefile (revision 403272) +++ Makefile (working copy) @@ -20,10 +20,10 @@ SHEBANG_FILES= index.cgi perl_OLD_CMD= /usr/pkg/bin/perl NO_BUILD= yes +NO_ARCH= yes do-install: ${MKDIR} ${STAGEDIR}${WWWDIR}/ - @cd ${WRKSRC}; ${FIND} . \ - | ${CPIO} -pdm -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR} + @cd ${WRKSRC}; ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR} .include <bsd.port.mk> Index: pkg-plist =================================================================== --- pkg-plist (revision 403272) +++ pkg-plist (working copy) @@ -2,4 +2,3 @@ %%WWWDIR%%/readme.html %%WWWDIR%%/.header.html %%WWWDIR%%/.footer.html -@dirrm %%WWWDIR%% ---