Bug 205218
| Summary: | [PATCH] science/mol2ps: Update to version 0.4b | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | tkato432 | ||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | marino, miwi, tkato432 | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | miwi:
maintainer-feedback?
(tkato432) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
http://pkgdev.miwibox.org/data/93i386-miwi/2015-12-18_08h00m17s/logs/errors/mol2ps-0.4b.log build fails on all archs. Can you please check. Created attachment 164348 [details]
science_mol2ps.diff
It seems there is some incompatibility between the latest freepascal
compiler and previous version.
I'll take it; I've fixed others like this. better you ask before you taking other prs. thanks! A commit references this bug: Author: marino Date: Mon Dec 21 11:40:00 UTC 2015 New revision: 404090 URL: https://svnweb.freebsd.org/changeset/ports/404090 Log: science/mol2ps: Upgrade version 0.4a => 0.4b and unbreak PR patch had to be modified after FPC was updated to 3.0.0 PR: 205218 Submitted by: Ports Fury Changes: head/science/mol2ps/Makefile head/science/mol2ps/distinfo 1) I didn't realize until now that a replacement patch had been provided 2) the replacement patch was wrong. Removing a unit declaration is not the solution. There's lots more PRs, plenty to go around. That does not change the fact that you just took a pr which not belongs to you, as long its not timeout! So please respect that in the first place! Conclusion: Asking is more important than correctness. This is way to trivial to get upset about. I'm sorry that I prevented you from making a bad commit. I'll let you do that next time. |
Created attachment 164074 [details] science_mol2ps.diff