Bug 205271

Summary: comms/fldigi switch to USES=execinfo, use options helpers
Product: Ports & Packages Reporter: Pawel Pekala <pawel>
Component: Individual Port(s)Assignee: Pawel Pekala <pawel>
Status: Closed FIXED    
Severity: Affects Only Me CC: hamradio, shurd
Priority: --- Keywords: patch
Version: LatestFlags: pawel: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fldigi modernize patch koobs: maintainer-approval+

Description Pawel Pekala freebsd_committer freebsd_triage 2015-12-12 17:06:34 UTC
Created attachment 164151 [details]
fldigi modernize patch

Small update of port to current standards:

- Remove pkg-config dependency from BUILD_DEPENDS, it's implied by USES=pkgconfig
- Switch to USES=execinfo, this will use external libexecinfo only when needed
- Use options helpers
- Remove usage of deprecated MAN1 variable, pkg-plist is handling this anyway
Comment 1 Stephen Hurd freebsd_committer freebsd_triage 2015-12-15 07:53:19 UTC
Looks good to me, feel free to commit if you've done test builds.  If not, I can test and commit tomorrow.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-15 19:58:36 UTC
A commit references this bug:

Author: pawel
Date: Tue Dec 15 19:58:17 UTC 2015
New revision: 403801
URL: https://svnweb.freebsd.org/changeset/ports/403801

Log:
  - Remove pkg-config dependency from BUILD_DEPENDS, it's
    implied by USES=pkgconfig
  - Switch to USES=execinfo, this will use external libexecinfo
    from ports only when needed
  - Use options helpers
  - Remove usage of deprecated MAN1 variable, pkg-plist is handling this anyway

  PR:		205271
  Submitted by:	me
  Approved by:	shurd

Changes:
  head/comms/fldigi/Makefile
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2015-12-15 20:00:55 UTC
I always do test builds before submitting patches, thanks.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-16 02:46:42 UTC
Assign to committer that resolved