Bug 205328

Summary:

devel/oniguruma5: Take MAINTAINER'ship, USE_GITHUB for DISTFILES

Product:

Ports & Packages

Reporter:

Robert Zelaya <rob>

Component:

Individual Port(s)

Assignee:

Thomas Zander <riggs>

Status:

Closed FIXED

Severity:

Affects Many People

CC:

koobs, riggs, rob

Priority:

---

Keywords:

easy, patch, patch-ready

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
oniguruma5-patch	none
Update patch using hash	none
Update patch using tag, add changes sugested by knoobs	none
Removed MasterSites line	koobs: maintainer-approval+

Description Robert Zelaya 2015-12-15 01:26:48 UTC

Created attachment 164249 [details]
oniguruma5-patch

UPDATE: oniguruma5

ISSUE: K.Kosako <kkosako0@gmail.com> has moved his source files from geocities.jp/kosako3/oniguruma/archive/ to github.com/kkos/oniguruma.

FIX: I have updated the oniguruma5/Makefile to use github. I have also set the Makefile to use cmake.

REF: github.com/stedolan/jq/issues/936 and http://web.archive.org/web/20150522232037/http://www.geocities.jp/kosako3


NOTES: I ahve followed (FreeBSD Ports: New Contributors 101) bitbucket.org/koobs/ports


Robert Z

Comment 1 Kubilay Kocak freebsd_committer

2015-12-15 02:21:26 UTC

Thanks for your submission Robert. At least few further tweaks are needed:

* GH_PROJECT is PORTNAME by default, you can remove this
* For GH_TAGNAME, if the repository has git tags, please use them instead of commit hashes. Note: GH_TAGNAME defaults to PORTVERSION already
* INSTALL_TARGET=install-strip shouldn't be removed without good reason.
* You should be able to use USES=pathfix instead of:

@${REINPLACE_CMD} -e 's|\$$(libdir)/pkgconfig| for CMakeLists.txt and Makefile.am

Also, why are .so.* and onig-config not installed when using the github sources?

Could you also please confirm this change passes QA (portlint, poudriere)

Comment 2 Robert Zelaya 2015-12-15 04:37:22 UTC

Thanks for the feed back.

1. I will remove GH_PROJECT from the diff.

2. INSTALL_TARGET=install-strip fails when using cmake.

3. GH_TAGNAME=hash is using git master branch. Kosako is fixing bugs only on that    branch. He has also moved to cmake in the last few months.

I can use the old source files from a year ago with tag=v5.9.6 if thats what you think we should do.

4. My patch I submitted past portlint, port test and poudriere built php56 with mbstring witch uses oniguruma5. (Note: I had to mod /usr/ports/Mk/bsd.php.mk).


Question, do we stay with the old oniguruma source files from a year ago using tag=v5.9.6 or use master branch with bug fixes.


Robert

Comment 3 Robert Zelaya 2015-12-15 04:59:26 UTC

Created attachment 164259 [details]
Update patch using hash

Comment 4 Robert Zelaya 2015-12-15 17:28:54 UTC

Created attachment 164276 [details]
Update patch using tag, add changes sugested by knoobs

1. Switch to github for fetch.

2. Use github tag v5.9.6.

3. Make sure pathfix works.

4. Change the MAINTAINER line to me :).

5. Testing PASSED with portlint, port test and poudriere built php56-mbstring with oniguruma5 with no issues.

Comment 5 Robert Zelaya 2015-12-16 02:28:22 UTC

Created attachment 164285 [details]
Removed MasterSites line

Removed MasterSites Line

Comment 6 Kubilay Kocak freebsd_committer

2015-12-16 02:37:25 UTC

Comment on attachment 164285 [details]
Removed MasterSites line

Port is unmaintained, implicit approval

Comment 7 commit-hook freebsd_committer

2015-12-19 09:51:21 UTC

A commit references this bug:

Author: riggs
Date: Sat Dec 19 09:50:49 UTC 2015
New revision: 404005
URL: https://svnweb.freebsd.org/changeset/ports/404005

Log:
  Fetch from GitHub; new maintainer Robert Zelaya <rob@theseusnetworking.com>

  PR:		205328
  Submitted by:	rob@theseusnetworking.com (maintainer)
  Reviewed by:	koobs

Changes:
  head/devel/oniguruma5/Makefile
  head/devel/oniguruma5/distinfo