Bug 205339
| Summary: | [PATCH] x11/kdelibs4: add options | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthew Rezny <rezny> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Some People | CC: | groot, pi, tcberner | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(kde) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | 210255 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
I've merged this patch into area51, the KDE-FreeBSD staging area. Thanks for submitting this! I will update PR210255 (the next KDE4 update) with the contents of this patch, so basically saying that this PR is merged with a later one. The PR can be closed as "overcome by events". We'll depend on 210255 and close this bug as soon as 210255 is closed. Fixed by the patch in PR#210255. |
Created attachment 164267 [details] add options to x11/kdelibs4 x11/kdelibs4 has had a rather odd dependency and pkg-message for quite some time; it unconditionally depends on hupnp in order to build the UPnP backend for Solid, but there is also a patch which disables that backend, and the pkg-message notes it is known to cause instability and so is disabled but can be enabled via an environment variable. WTF?! Why build something just to leave it disabled, and if it's known to cause instability why is it being built at all? Restore some sanity to this port with a couple options: AVAHI and UPNP. The UPNP option replaces the hack with a normal option, which allows the patch and pkg-message to be removed. The AVAHI option simply makes that dependency optional since it is not required for KDE. The defaults of the new options are in keeping with past behavior, AVAHI is on as it was, UPNP is off because is is known unstable and the functionality was previously disabled. So, the only functional change is to drop a useless dependency by default.