Summary: | [NEW PORT] databases/libcouchbase: Multithreaded noSQL database (client and library) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | gebhart | ||||||||||
Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | gebhart, pi, sergey.avseyev | ||||||||||
Priority: | --- | Keywords: | feature, patch-ready | ||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
URL: | https://github.com/couchbase/libcouchbase/ | ||||||||||||
Attachments: |
|
Description
gebhart
2015-12-17 15:23:47 UTC
Please, can you check the submission with portlint -AC There are issues in the Makefile and the pkg-plist. (In reply to Kurt Jaeger from comment #1) Oh, ok. I only checked with portlint without any options. I will fix that and upload a new shar. Created attachment 166081 [details]
fixed .shar file
Ok, here is the updated .shar file.
This time it passes "portlint -AC" and also "port test ..."
Testbuilds@work Fails to build in poudriere due to dtrace issues (!) See for example http://people.freebsd.org/~pi/logs/databases__libcouchbase-10a-1453722509.txt or the other files. If we set LCB_BUILD_DTRACE OFF in CMakeLists, then it fails while downloading http://packages.couchbase.com/clients/c/mock/CouchbaseMock-1.2.0-g85062e3.jar which is not allowed while running in poudriere. The necessary distfiles need to be downloaded in the fetch phase. See http://people.freebsd.org/~pi/logs/databases__libcouchbase-10a-1453724462.txt etc. (In reply to Kurt Jaeger from comment #5) Thank you. In the meantime I've also set up poudriere and can now better check it. I thought it's only making a network connection to localhost for testing but obviously it does more :-( I'll have a look at it. Comment on attachment 166081 [details]
fixed .shar file
Fails QA
Created attachment 173308 [details]
Updated to libcouchbase-2.6.2, re-enabled DTrace probes, marked as unsafe for parallel make
Please, do not disable DTrace in libcouchbase, the problem is that it is generated by custom perl-script which does not work with parallel build.
I will take ownership on this as I part of Couchbase SDK team, and my PHP extension is depending on libcouchbase.
I test-built on 12a, 11a, 10i, 9.3a with poudriere. All builds at the same place. See for example: http://people.freebsd.org/~pi/logs/databases__libcouchbase-11a-1472848864.txt Any ideas on how to make it build in poudriere ? It builds on 12a outside of poudriere, btw. Created attachment 174326 [details]
Removed configure script invocation (just use CMake), do not compile tests (skips mock jar file downloading)
Testbuilds are ok with small modification. A commit references this bug: Author: pi Date: Sat Sep 3 06:24:28 UTC 2016 New revision: 421281 URL: https://svnweb.freebsd.org/changeset/ports/421281 Log: New port: databases/libcouchbase This is the C client library for Couchbase. It communicates with the cluster and speaks the relevant protocols necessary to connect to the cluster and execute data operations. https://github.com/couchbase/libcouchbase/ PR: 205377 Submitted by: gebhart@secnetix.de, Sergey Avseyev <sergey.avseyev@gmail.com> Changes: head/databases/Makefile head/databases/libcouchbase/ head/databases/libcouchbase/Makefile head/databases/libcouchbase/distinfo head/databases/libcouchbase/files/ head/databases/libcouchbase/files/patch-CMakeLists.txt head/databases/libcouchbase/pkg-descr head/databases/libcouchbase/pkg-plist Committed, and thanks for your persistence! A commit references this bug: Author: danfe Date: Fri Apr 21 22:02:02 UTC 2017 New revision: 439130 URL: https://svnweb.freebsd.org/changeset/ports/439130 Log: Remove MAKE_JOBS_UNSAFE marker: it was added as part of r421281 upon the port's inception as of version 2.6.2, however, it was neither present in submitted PR nor explained in the original commit log by pi@. So far my quick tests do not show evidence that it is parallel-build unsafe. We'll ask for forgiveness if it is indeed broken against -j X builds and reinstate MAKE_JOBS_UNSAFE, but with a proper explanation this time. While here, remove needless += from CMAKE_ARGS and place them at a better location within the Makefile. PR: 205377 Changes: head/databases/libcouchbase/Makefile |