Bug 205452

Summary: emulators/virtualbox-ose-kmod: patch needed after vm_pageout_grow_cache() removed
Product: Ports & Packages Reporter: Mark Johnston <markj>
Component: Individual Port(s)Assignee: Jung-uk Kim <jkim>
Status: Closed FIXED    
Severity: Affects Some People CC: jkim
Priority: --- Keywords: needs-qa, patch, patch-ready, regression
Version: LatestFlags: bugzilla: maintainer-feedback? (vbox)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
virtualbox patch update
none
Fix build after vm_pageout_grow_cache() removal none

Description Mark Johnston freebsd_committer freebsd_triage 2015-12-20 06:00:56 UTC 
Created attachment 164410 [details]
virtualbox patch update

A recent change to the base system (r292469) removed a VM function that the virtualbox kernel modules uses. I've attached a patch which fixes it. See https://lists.freebsd.org/pipermail/freebsd-current/2015-December/059005.html

I note that the patch (generated by "make makepatch") contains some unrelated cosmetic changes, but from reading the makepatch script, they appear to be intended.
Comment 1 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 20:00:33 UTC 
I'll take it.
Comment 2 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 20:49:47 UTC 
Created attachment 164465 [details]
Fix build after vm_pageout_grow_cache() removal

Please try this patch and let me know.
Comment 3 Mark Johnston freebsd_committer freebsd_triage 2015-12-21 21:57:39 UTC 
It seems to be ok. I omitted the VM_WAIT in my original patch because I can't tell if that code might be executed in a non-sleepable context.
Comment 4 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 22:28:41 UTC 
(In reply to Mark Johnston from comment #3)
Actually, I am not 100% sure whether we can sleep any more.  I'll just commit yours for now.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-12-21 22:34:28 UTC 
A commit references this bug:

Author: jkim
Date: Mon Dec 21 22:34:02 UTC 2015
New revision: 404195
URL: https://svnweb.freebsd.org/changeset/ports/404195

Log:
  Fix build on head after vm_pageout_grow_cache() removal.

  PR:		205452

Changes:
  head/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r0drv-freebsd-memobj-r0drv-freebsd.c
Comment 6 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-21 22:35:51 UTC 
Committed (r404195), thanks!