Summary: | www/squid: Building v3.5.12 with heimdal fails | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | dewayne | ||||||
Component: | Individual Port(s) | Assignee: | Jason Unovitch <junovitch> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | junovitch, timp87 | ||||||
Priority: | --- | Keywords: | easy, patch-ready | ||||||
Version: | Latest | Flags: | koobs:
maintainer-feedback+
junovitch: merge-quarterly+ |
||||||
Hardware: | amd64 | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
dewayne
2015-12-20 14:19:30 UTC
Created attachment 164421 [details]
squid 3.5.12 config.log.xz with failure outcome
Hi! I think I know what led to this fault. I upgraded www/squid to 3.5.12 release and deleted self-written ugly patch because upstream 'fixed' it. It's a part of patch-configure patch. https://svnweb.freebsd.org/ports?view=revision&revision=403151 Sorry, I should have checked it better. I suggest you to checkout from svn not only Makefile, but all www/squid dir of 3.5.11 release. I'll try look at it closely tomorrow. Sorry, I need more time to find a solution than I expected. Created attachment 164894 [details]
fix
Fix squid build with Heimdal from ports.
Additionally fix squid build with base Heimdal when Heimdal from ports is installed.
I khow, it's pretty stupid and direct.
IMO this should be fixed by upstream. I'm going to create bug report in squid bugzilla for that.
P. S. sorry for the delay. I've been reeeally busy.
@Tim, does this need to be MFH'd ? Also, don't forget to set maintainer-approval to + on your own attachments, or those that you approve created by others on ports you maintain :) @Dewayne, could you confirm whether this patch resolves the issue for you please? (In reply to Kubilay Kocak from comment #5) It defininitely has to be MFH'd if squid 3.5.12 is there. Sorry, I forget it every time. (In reply to timp87 from comment #7) That's OK, it will be automated soon (at least for your patches you create) :] (In reply to Kubilay Kocak from comment #6) Thank-you for pursuing. Yes, appling the patch enables a successful build on both amd64 and i386 servers, which are now running squid 3.5.12 quite happily. A commit references this bug: Author: junovitch Date: Tue Jan 5 01:52:09 UTC 2016 New revision: 405267 URL: https://svnweb.freebsd.org/changeset/ports/405267 Log: www/squid: Heimdal option build fixes - Fix squid build with Heimdal from ports. - Additionally fix squid build with base Heimdal when Heimdal from ports is installed. PR: 205461 Reported by: dewayne@heuristicsystems.com.au Submitted by: Pavel Timofeev <timp87@gmail.com> (maintainer) MFH: 2016Q1 (build fix blanket) Changes: head/www/squid/files/patch-configure A commit references this bug: Author: junovitch Date: Tue Jan 5 01:52:53 UTC 2016 New revision: 405268 URL: https://svnweb.freebsd.org/changeset/ports/405268 Log: MFH: r405267 www/squid: Heimdal option build fixes - Fix squid build with Heimdal from ports. - Additionally fix squid build with base Heimdal when Heimdal from ports is installed. PR: 205461 Reported by: dewayne@heuristicsystems.com.au Submitted by: Pavel Timofeev <timp87@gmail.com> (maintainer) Approved by: ports-secteam blanket Changes: _U branches/2016Q1/ branches/2016Q1/www/squid/files/patch-configure Dewayne, Thank you for reporting and testing this patch. Pavel, Thanks for your continued efforts taking care of Squid and working with upstream to get this fixed in the future. |