Bug 205473

Summary: irc/znc: Update to 1.6.2
Product: Ports & Packages Reporter: Matthew Rezny <rezny>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Some People CC: riggs
Priority: --- Keywords: easy, patch, patch-ready
Version: LatestFlags: rezny: maintainer-feedback-
Hardware: Any   
OS: Any   
Attachments:
Description Flags
update irc/znc to 1.6.2
none
update irc/znc to 1.6.2 koobs: maintainer-approval+

Description Matthew Rezny freebsd_committer freebsd_triage 2015-12-21 00:17:14 UTC
Created attachment 164438 [details]
update irc/znc to 1.6.2

Trivial update of ZNC to 1.6.2.
Comment 1 Matthew Rezny freebsd_committer freebsd_triage 2015-12-27 18:43:51 UTC
Created attachment 164731 [details]
update irc/znc to 1.6.2

I have updated the patch to some cleanup on the port along with the update.

Barnerd pointed out the OPENSSL option should USE_OPENSSL rather than including the openssl.mk directly. So, I cleaned up all the options; they are now alphabetized and the .if blocks were converted to use options-helpers.

One new patch has been added to address warnings from Clang about unused flags, -L  is getting passed during compilation. The configure script has wrong starting values for our platform. These corrections have been made:
-L /usr/local/lib is nor added to only LDFLAGS, not to the Libs and not to the MODFLAGS which are passed during module compilation
-lcompat is removed from Libs as it is not needed anymore
-D__GNU_SOURCE__ is removed from CXXFLAGS as it is not needed anymore

The apparently obsolete patch for modperl is removed, there was no difference in the build with or without it. Everything was tested in poudriere on 9.3 and 10.2 releases for amd64 and i386.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-11 19:17:12 UTC
Maintainer timeout, 20+ days.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-11 19:17:39 UTC
Comment on attachment 164731 [details]
update irc/znc to 1.6.2

Maintainer timeout (20+ days) implicit approval
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-01-18 18:58:43 UTC
A commit references this bug:

Author: riggs
Date: Mon Jan 18 18:58:35 UTC 2016
New revision: 406604
URL: https://svnweb.freebsd.org/changeset/ports/406604

Log:
  Update to upstream release 1.6.2, cleanup port

  Cleanups:
  - USE_OPENSSL
  - Convert to OPTION helpers
  - Remove no longer necessary patch for modperl
  - Sort OPTIONs
  - Correct compiler flags detection in configure script

  PR:		205473
  Submitted by:	matthew@reztek.cz
  Reviewed by:	riggs
  Approved by:	maintainer timeout

Changes:
  head/irc/znc/Makefile
  head/irc/znc/distinfo
  head/irc/znc/files/patch-configure
  head/irc/znc/files/patch-modules-modperl-Makefile_inc
  head/irc/znc/files/patch-src_Csocket.cpp