Bug 205475
| Summary: | [NEW PORT] x11-themes/gtk-E17-theme: Dark GTK theme for Enlightenment | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthew Rezny <rezny> | ||||||||
| Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | Keywords: | feature, patch, patch-ready | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Comment on attachment 164442 [details]
add x11-themes/gtk-E17-gtk
New ports dont (yet) have a maintainer to approve
@Matthew, can you confirm this passes QA please? (portlint, poudriere). Logs as attachments are not necessary Created attachment 164454 [details] add port x11-themes/gtk-E17-theme The mention of poudriere testing prompted me to realize this should have NO_ARCH set. I assume it was an oversight that it is not set in the other theme ports I was cribbing from when putting this port together. /usr/ports/x11-themes/gtk-E17-theme # portlint -AC WARN: Makefile: Consider defining LICENSE. 0 fatal errors and 1 warning found. Portlint is happy except for license, which I can do nothing about. There is no mention of license in the distributed files at all. The website simply says "License: GPL", and while LICENSE=GPL makes portlint happy, it causes make to fail. Leaving it blank rather than trying to guess a GPL version. I guess some clarification is needed regarding the maintainer flag. I was previously told it should be set on ports without a maintainer, i.e. MAINTAINER=ports@FreeBSD.org. A new port also has no current maintainer so logically the same should apply. Created attachment 164455 [details]
poudriere log
(In reply to matthew from comment #3) maintainer-approval only applies to existing ports without a maintainer (since by definition a maintainer cant approve the change), and new port doesn't yet have a maintainer, until it's committed This change is nonetheless good to go. (In reply to Kubilay Kocak from comment #5) Since a new port has no maintainer until its committed, by definition there is no maintainer to approve, exactly the same as an existing port without maintainer. I'm still waiting some logical explanation for the difference in handling, and that should include an explanation of why maintainer-approval exists but is not used in such a way to be useful filter criteria. This dead simple theme port sits for weeks. Is that because it doesn't show up in Maintainer Approved saved search that committers with a free moment might look at first? Matthew has waited too long, and this port doesn't depend on an entire X/Desktop stack (contrary to what I assumed) A commit references this bug: Author: koobs Date: Tue Feb 2 17:51:52 UTC 2016 New revision: 407831 URL: https://svnweb.freebsd.org/changeset/ports/407831 Log: [NEW] x11-themes/gtk-E17-theme: Dark GTK theme for Enlightenment E17gtk is a dark Gtk theme with sharp corners, which is designed for use in Enlightenment and gives the elegant look of Enlightenment to Gtk3, Gtk2 and Qt widgets. Of course, it can be used with any GTK based environment too, but it is not tuned to Gnome or any of its apps. WWW: http://gnome-look.org/content/show.php/?content=163472 PR: 205475 Submitted by: Matthew <matthew reztek cz> Changes: head/x11-themes/Makefile head/x11-themes/gtk-E17-theme/ head/x11-themes/gtk-E17-theme/Makefile head/x11-themes/gtk-E17-theme/distinfo head/x11-themes/gtk-E17-theme/pkg-descr head/x11-themes/gtk-E17-theme/pkg-plist Committed, apologies for the delay Matthew |
Created attachment 164442 [details] add x11-themes/gtk-E17-gtk New Port pkg-descr: E17gtk is a dark Gtk theme with sharp corners, which is designed for use in Enlightenment and gives the elegant look of Enlightenment to Gtk3, Gtk2 and Qt widgets. Of course, it can be used with any GTK based environment too, but it is not tuned to Gnome or any of its apps.