Bug 205504
| Summary: | [REVIVE PORT] audio/ampache version 3.8.1 | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | git | ||||||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||||||
| Status: | Closed Feedback Timeout | ||||||||||||||||||||
| Severity: | Affects Only Me | CC: | andrej, jadawin | ||||||||||||||||||
| Priority: | --- | Keywords: | feature, needs-patch, needs-qa | ||||||||||||||||||
| Version: | Latest | ||||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||||
| OS: | Any | ||||||||||||||||||||
| URL: | https://github.com/johnko/freebsd-ports-ampache | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Thanks for the submission. Can you please attach a patch against the ports' svn tree? The process of revival is described here (steps 1-6): https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-re-adding The port was removed in revision 402562, so you will need the one before that: https://svnweb.freebsd.org/ports?view=revision&revision=402562 Also please test the port with portlint and poudriere. * CC-ing previous maintainer in case they're interested. I found an issue in my pkg-plist where I blindly added all files that php-composer fetched. I fixed part of it by manually excluding anything matching .*/.git/.* I'm worried that php-composer could pull different versions of files than those listed in pkg-plist because it pulls from master on some dependency's repos. I'm running some more tests before I submit a final patch. Created attachment 172700 [details]
poudriere log
Here's a poudriere test log for the port that's on github at the moment.
There are some warnings for the Makefile:
WANT_PHP_WEB is deprecated, please use USES=php:web
Using USE_PHP alone is deprecated, please use USES=php
And composer fails to fetch anything, I think beacause it is not allowed in the stage phase?
Created attachment 172701 [details]
poudriere-portlint log
Also some portlint warnings and errors.
Created attachment 172704 [details]
diff against svn
Here's a svn diff with some of the portlint errors and make warnings fixed. composer still can't fetch anything, though.
Created attachment 172705 [details]
poudriere log
Created attachment 172706 [details]
poudriere-portlint log
What is the proper way of using php-composer in ports anyway? Couldn't find any docs/examples. Created attachment 172713 [details] svn diff for version 3.8.2 - without composer So ampache also has a release with all the dependencies already in it, without the need for composer: ampache-[version]_all.zip, see https://github.com/ampache/ampache/wiki/Installation#composer I made modified the port for this version (without depending on composer and git), fixed some things, it builds, installs and deinstalls fine, but haven't tested running it yet. Also, I think mysql-server has to be added as a dependency, since ampache need a MySQL instance. The pkg-plist ist (mostly) auto-generated, and I'm not so sure if the permissions are right on all the files/folders. All in all it needs further work and testing, but should be a good starting point without dealing with composer. Created attachment 172714 [details]
poudriere log without composer
Created attachment 172715 [details]
poudriere-portlint log without composer
Is this still relevant? If yes then this needs an update to 3.8.6 and somebody should put this up for review on https://reviews.freebsd.org/. I'll try to make an updated port/diff this weekend. How do I submit something for rewiew? (In reply to Andrej Ebert from comment #13) See https://wiki.freebsd.org/Phabricator Ping |
Is it proper to call `composer` in the Makefile? It appears to be needed to install other dependencies. Link to Makefile line with `composer`: https://github.com/johnko/freebsd-ports-ampache/blob/af964982682a310fe3284ff3c4e986cd947ac7ec/audio/ampache/Makefile#L47 Link to Makefile, distinfo, pkg-plist, etc.: https://github.com/johnko/freebsd-ports-ampache With that Makefile and etc., this works: make && make install && make package