Bug 205753

Summary:

[PATCH] mail/automx still contains bash-only code

Product:

Ports & Packages

Reporter:

Martin Waschbüsch <martin>

Component:

Individual Port(s)

Assignee:

Chris Rees <crees>

Status:

Closed FIXED

Severity:

Affects Some People

Keywords:

patch

Priority:

---

Flags:

bugzilla: maintainer-feedback? (crees)

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
replace bash-ism by use of sed.	none
replace bash-ism.	none

Description Martin Waschbüsch 2015-12-31 09:26:33 UTC

mail/automx still contained bash-only code: string expansion with search and replace is not supported by vanilla sh.

Fixed by using sed (patch attached).

Comment 1 Martin Waschbüsch 2015-12-31 09:28:08 UTC

Created attachment 164895 [details]
replace bash-ism by use of sed.

replace bash-ism by use of sed in automx-test.

Comment 2 Chris Rees freebsd_committer

2015-12-31 09:43:19 UTC

Nice, but doesn't ${AUTODISC##* } do the same?

Chris

Comment 3 Martin Waschbüsch 2015-12-31 15:56:19 UTC

Created attachment 164901 [details]
replace bash-ism.

Indeed, it does!

Just goes to show how little I know about all the magic that is shell... :-)
I'd go with your suggestion - it's way more elegant. (patch updated)

Comment 4 Chris Rees freebsd_committer

2015-12-31 20:44:30 UTC

Committed.  Thanks!