Summary: | mail/sqlgrey: Fix missing dependencies (bash, wget, md5sum) | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Christian Schwarz <me> | ||||||||||||
Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||
Status: | Closed FIXED | ||||||||||||||
Severity: | Affects Many People | CC: | brd, koobs, pi | ||||||||||||
Priority: | --- | Keywords: | patch, patch-ready | ||||||||||||
Version: | Latest | Flags: | koobs:
merge-quarterly?
|
||||||||||||
Hardware: | Any | ||||||||||||||
OS: | Any | ||||||||||||||
Attachments: |
|
Description
Christian Schwarz
2015-12-31 11:34:58 UTC
A more comprehensive list of missing dependencies of update_sqlgrey_config: - bash - md5sum - wget md5sum seems problematic: I cannot find it in the ports tree. Maybe patch the script? Created attachment 164896 [details]
Patch for update_sqlgrey_config
Apply using:
patch /usr/local/sbin/update_sqlgrey_config /root/patch
@Christian, given this port doesn't currently have a maintainer, you can assist resolving of this issue with the following: * Create an svn (unified) diff against the mail/sqlgrey port itself after patching the script. For a super easy way see: http://www2.au.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#slow-patch * You mentioned a wget dependency but didn't provide any detail. Can you provide more detail? Has this script worked for you prior to this report or a previous port update? Created attachment 164904 [details]
SVN Diff for the actual port.
(In reply to me from comment #4) I attached a patch sqlgrey-1.8.0_1.diff. Since the diff doesn't change is a port-bugfix and not a version-incrementation, I suggest to include the patch in the 2015Q4 / 2016Q1 branch of the ports tree. Created attachment 165217 [details]
SVN Diff for the actual port.
Created attachment 165218 [details]
Output of the portlint -AC command.
Created attachment 165219 [details]
Output of the `port test` command.
Nice work Christian! :) Comment on attachment 165217 [details]
SVN Diff for the actual port.
Port is unmaintained, implicit approval
A commit references this bug: Author: pi Date: Mon Jan 18 19:48:36 UTC 2016 New revision: 406608 URL: https://svnweb.freebsd.org/changeset/ports/406608 Log: mail/sqlgrey: Fix missing dependencies (bash, wget, md5sum) PR: 205754 Submitted by: me@cschwarz.com Changes: head/mail/sqlgrey/Makefile head/mail/sqlgrey/files/patch-ipv6 head/mail/sqlgrey/files/patch-sqlgrey head/mail/sqlgrey/files/patch-update__sqlgrey__config Testbuilds fine 11a, 10.2a+i, 9.3a. Committed, thanks. @Kurt, could you add a comment for merge -, for our future selves :) (In reply to commit-hook from comment #11) Requesting merge-back to 2016Q1. This is merely a port bugfix and not a version update. Those missing DEPs existed since approx. 2012 and were probably not that urgent that it really requires a MFH. And I still do not understand the process for MFH 8-) (In reply to Kurt Jaeger from comment #15) I fixed it for you: https://wiki.freebsd.org/PortsSubversionPrimer#Quarterly_Branch :) Hey Christian, Do you use the update_sqlgrey_config shell script? I was thinking it would be easy to convert to not need bash or md5sum and use sh and md5. Would you be able to help test? Thanks, Brad DAvis (In reply to Brad Davis from comment #17) I run it in a cronjob, that's all it's good for. I can help you test but I think the only critical aspect is handling the different formats of md5 and md5sum (or knowing the right command line flags). Where does it fetch from? Could I get a copy of the file it is fetching? Thanks, Brad Davis (In reply to Brad Davis from comment #19) The standard file is fetched from the 'whitelist_host': > http://sqlgrey.bouton.name/MD5SUMS yes, you got that right, it's HTTP :( |