Bug 205817
| Summary: | [PATCH] update sysutils/pefs-kmod to support D3929 (r292782) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Eric Camachat <eric> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Gleb Kurtsou <gleb> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | eric, mikael | ||||||||||
| Priority: | --- | Keywords: | needs-qa, patch, regression | ||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(gleb) koobs: merge-quarterly? |
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Do any of these changes (patches) need to be conditional on OSVERSION, or have all of the relevant commits referenced (r292782 [1], r263218 [2]) been MFC'd to all stable (9,10) branches? [1] https://svnweb.freebsd.org/base?view=revision&revision=292782 [2] https://svnweb.freebsd.org/base?view=revision&revision=263218 FYI sendfile merge in r292373 broke mmap in pefs. I'm looking into it. Created attachment 167496 [details]
Fix on newer FreeBSD
Fix on my r296151 11.0-CURRENT.
Created attachment 167579 [details] Update port to 2016-02-18 version Workaround for vnode pager issue and build fix has been committed upstream at https://github.com/glk/pefs More info on vnode pager issue: http://marc.info/?l=freebsd-commits-all&m=145549112823518&w=2 Patch to update the port attached. Eric could you please verify it works for you. I don't really see a difference between your two patches, so how does the later one fix the build? Could you elaborate. You're right, it was a building issue. Created attachment 167614 [details]
updated diff file
After some re-test, I found that I didn't `svn add` new files. So the new files were not included in previous patch.
Regardless, does the updated version 2016-02-18 work for you? I intend to get it committed shortly. 2016-02-18 works for me. Gleb, I'm also a pefs user and your patch works fine! Thanks a lot. A commit references this bug: Author: sbruno Date: Thu Mar 3 14:22:14 UTC 2016 New revision: 410041 URL: https://svnweb.freebsd.org/changeset/ports/410041 Log: Update port to 20016-02-18. PR: 205817 Submitted by: gleb Changes: head/sysutils/pefs-kmod/Makefile head/sysutils/pefs-kmod/distinfo |
Created attachment 164980 [details] Replace sha2.{c,h} by sha512{c.c,.h}. After D3929 (r292782), "kldload pefs" will complain "SHA512_Init undefined". The comments in r292782 mentioned all sha2.{c,h} should be replaced by sha512{c.c,.h}, and here is the patch that does it.