Bug 205830
| Summary: | [PATCH] ports-mgmt/portshaker: simplification of Makefile depend logic | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Simon Wright <simon.wright> | ||||||
| Component: | Individual Port(s) | Assignee: | Romain Tartière <romain> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | amdmi3, lev | ||||||
| Priority: | --- | Keywords: | patch | ||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(romain) |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 164991 [details]
Logs from with and without WITH_SUBVERSION_VER set
What if WITH_SUBVERSION_VER=19? While I quite agree with the change, other ports that depend on $WITH_SUBVERSION_VER (devel/py-subversion, www/mod_dav_svn) have the same construct that is currently used. Adding lev@ — the maintainer of these ports — in copy so that he can help us with his insights. A commit references this bug: Author: romain Date: Tue Jan 16 09:17:05 UTC 2018 New revision: 459162 URL: https://svnweb.freebsd.org/changeset/ports/459162 Log: Update to 1.0.15 This release address a few minor issues, including [2]. While here: - Simplify Makefile depend logic [1]; - Add license. PR: 205830 [1], 224138 [2] Submitted by: simon.wright@gmx.net [1], parakleta@darkreality.org [2] Changes: head/ports-mgmt/portshaker/Makefile head/ports-mgmt/portshaker/distinfo Found this old PR, the proposed changed was sitting in my local ports for a while, and was long overdue… I just committed it. Thank you! |
Created attachment 164990 [details] Patch to simplify Makefile depends logic Looking at the subversion run dependancy wouldn't the attached be a simpler form of the requirement? If WITH_SUBVERSION_VER is defined it will be used, if it isn't it will be empty and the default will be used.