Summary: | ports-mgmt/pkg crash if env variable HTTP_USER_AGENT is empty | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Andrew Romanenko <melanhit> |
Component: | Individual Port(s) | Assignee: | freebsd-pkg (Nobody) <pkg> |
Status: | Closed FIXED | ||
Severity: | Affects Many People | CC: | junovitch, melanhit, tobik |
Priority: | --- | Flags: | junovitch:
merge-quarterly-
|
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
Andrew Romanenko
2016-01-07 12:15:29 UTC
I've proposed a fix here: https://github.com/freebsd/pkg/pull/1371 this patch exclude "User-Agent" string in the http header (if HTTP_USER_AGENT is empty) Updated the patch to set a default user agent in that case The fixes referenced in the pull request in comment 1 were part of pkg-1.6.3 release. https://github.com/freebsd/pkg/commit/7ced9c23cba5d8b8b414893e0155c582712fbbc1 https://github.com/freebsd/pkg/commit/2198138887b23ce9fcfd16bbca9baaee112e2c4e Actually, it's still pkg-1.6.2 in 2016Q1, so reopen and set merge-quarterly?. Sorry about that. yes, needs to create a new pull request? or it can be merged? (In reply to Andrew Romanenko from comment #6) No action on your part is needed. According to https://svnweb.FreeBSD.org/changeset/ports/407329 on 26 Jan pkg-1.6.3 was planned to be merge in 10 days. This is just waiting on a pkg@ person to declare it or a subsequent version is ready to go. Another issue was fixed in the meantime, as soon as I consider latest pkg stable enough I will merge it. (In reply to Baptiste Daroussin from comment #8) I'm marking this as closed now as 2016Q2 was branched with pkg-1.7.X and this issue was fixed in pkg-1.6.3. Setting merge-quarterly- as it wasn't merged and it's irrelevant now. |