Bug 206094

Summary: devel/arcanist: Updating diffs fails for repocopies with svn mv-ed or rm-ed files
Product: Services Reporter: Bernard Spil <brnrd>
Component: Code ReviewAssignee: Phabric Admin <phabric-admin>
Status: Closed FIXED    
Severity: Affects Only Me CC: allanjude, eadler
Priority: --- Keywords: needs-qa
Version: unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
arc --trace log none

Description Bernard Spil freebsd_committer freebsd_triage 2016-01-10 11:22:36 UTC
Created attachment 165352 [details]
arc --trace log

I've repocopied databases/mariadb100-server and -client to mariadb101-server and -client to create new ports for MariaDB 10.1.
Some patches in the 10.0 version were not adhering to the naming standard. These files were renamed using svn mv or removed using svn rm.

When updating the revision with the latest patches I get an error on the renamed or deleted files

Deleted file example:
> $ arc diff --update D3953 Mk/bsd.database.mk databases/mariadb101-server databases/mariadb101-client
> Linting...
> No lint engine configured for this project.
> Running unit tests...
> No unit test engine is configured for this project.
> Exception
> svn diff returned unexpected error code: 1
> stdout:
> stderr: svn: E155035: Expected node '/usr/ports/databases/mariadb101-server/files/patch-extra_yassl_taocrypt_src_integer.cpp' to be added.
> 
> (Run with `--trace` for a full exception trace.)

Renamed file example:
> $ arc diff --update D3953 Mk/bsd.database.mk databases/mariadb101-client databases/mariadb101-server
Linting...
> No lint engine configured for this project.
> Running unit tests...
> No unit test engine is configured for this project.
> Exception
> svn diff returned unexpected error code: 1
> stdout:
> stderr: svn: E155035: Expected node '/usr/ports/databases/mariadb101-client/files/patch-include_my_compare.h' to be added.
> 
> (Run with `--trace` for a full exception trace.)

Uploading the output of svn diff was successful
Comment 1 Allan Jude freebsd_committer freebsd_triage 2016-06-05 22:27:17 UTC
My patch has been committed upstream: https://secure.phabricator.com/D15985

It will be in the port after the next release