Bug 206163
| Summary: | net/megatools: Update to 1.9.96 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Max Kostikov <max> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | max, riggs | ||||||||||||
| Priority: | --- | Keywords: | easy, patch, patch-ready | ||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 165446 [details]
distinfo diff
@Max, single patches are preferred, can you create a new combined diff and obsolete the existing attachments please? Sure - see new patch attached Created attachment 165481 [details]
combined patch
Thanks Max! You can obsolete the previous attachments by going to Attachment -> Details -> Edit Details -> [X] Obsolete. There's no need to 'unapprove them' after this has been done, as they will no longer be visible by default Created attachment 165482 [details]
new combined patch file
Done! @Max perfect :) We can encourage progress on this issue a little faster, if you can confirm that these changes pass QA (quality assurance) via portlint and poudriere For more information on testing changes (QA), see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html portlint gave 0 fatals, about poudriere I don't made any tests yet @Max, You can run the following command in the meantime, which covers most, but not all of poudriere's tests: make stage && make check-plist && make stage-qa && make package Feel free to just confirm that this runs fine if it passes, instead of attaching the output. If it doesn't pass, fix any issues and update patch attachments All make's passed without errors but only have one warning with I did not know what I should do >/!\ megatools-1.9.96: Makefile warnings, please consider fixing /!\ > >Not validating first entry in CATEGORIES due to being outside of PORTSDIR. Please ensure this is proper when committing. @Max, having looked at the patch, I can see that it doesnt appear to be a properly formatted unified diff (with ! lines, instead of -/+ lines. How are you generating the diff, and are you using a full svn tree to create the diffs, or just diffing a copy of the net/megatools dir on its own with updates? I think we can ignore the warning, depending on your answers to the above questions (In reply to Kubilay Kocak from comment #13) This is context format of diff patch file. I will replace it right now to standard diff -u Created attachment 165488 [details]
patch to 1.9.96
Lovely! The port doesn't fetch under 9.x: => Attempting to fetch http://megatools.megous.com/builds/megatools-1.9.96.tar.gz fetch: http://megatools.megous.com/builds/megatools-1.9.96.tar.gz: Authentication error (In reply to Dmitry Marakasov from comment #17) Looks like you got some temporarily network problems. Now all fine from my side: > xm@beta:~/megatools # make fetch > ===> License GPLv2 accepted by the user > ===> Found saved configuration for megatools-1.9.96 > ===> megatools-1.9.96 depends on file: /usr/local/sbin/pkg - found > => megatools-1.9.96.tar.gz doesn't seem to exist in /usr/ports/distfiles/. > => Attempting to fetch http://megatools.megous.com/builds/megatools-1.9.96.tar.gz > megatools-1.9.96.tar.gz 100% of 446 kB 600 kBps 00m01s > ===> Fetching all distfiles required by megatools-1.9.96 for building > xm@beta:~/megatools # make fetch A commit references this bug: Author: riggs Date: Sun Jan 24 18:17:19 UTC 2016 New revision: 407170 URL: https://svnweb.freebsd.org/changeset/ports/407170 Log: Update to upstream version 1.9.96 PR: 206163 Submitted by: max@kostikov.co (maintainer) Changes: head/net/megatools/Makefile head/net/megatools/distinfo |
Created attachment 165445 [details] Makefile diff minor bugfixes