Summary: | www/foswiki remove deprecated @dirrm, convert to options helpers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Pawel Pekala <pawel> | ||||||
Component: | Ports Framework | Assignee: | Pawel Pekala <pawel> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | portmaster, ports-bugs | ||||||
Priority: | --- | Flags: | portmaster:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
(In reply to Pawel Pekala from comment #0) > Created attachment 165689 [details] > @dirrm & other fixes > > - Remove create-plist target using deprecated @dirrm > - Add NO_ARCH > - Don't prefix options descriptions with Installs, this makes > them folllow global naming standards > - Convert to options helpers > - Use FOSCONFDIR for files substitutions, CONFDIR is set earlier > and defaults to /etc, now pkg-message have correct paths > - Fix plist when APACHE=on The patch looks good, Pawel. Not that I doubt it. But I don't suppose you have any evidence it works as intended, do you? I should probably give it a go, and post the results. Thanks for taking the time to do this, Pawel! --Chris Created attachment 165703 [details]
@dirrm & other fixes
Fix one minor issue, add pkg-message-noapache to SUB_FILES when APACHE=off
lost when converting to options helpers.
Patch was developed on 11.0-CUREENT and here are poudriere build logs for other supported branches: http://people.freebsd.org/~pawel/buildlogs/foswiki-1.1.9-9amd64.log http://people.freebsd.org/~pawel/buildlogs/foswiki-1.1.9-10amd64.log http://people.freebsd.org/~pawel/buildlogs/foswiki-1.1.9-9amd64-apache.log http://people.freebsd.org/~pawel/buildlogs/foswiki-1.1.9-10amd64-apache.log Comment on attachment 165703 [details]
@dirrm & other fixes
Looks great, Pawel.
Thanks for all the time, and work you put into this!
--Chris
A commit references this bug: Author: pawel Date: Mon Jan 18 16:04:23 UTC 2016 New revision: 406592 URL: https://svnweb.freebsd.org/changeset/ports/406592 Log: - Remove create-plist target using deprecated @dirrm - Add NO_ARCH - Don't prefix options descriptions with Installs, this makes them folllow global naming standards - Convert to options helpers - Use FOSCONFDIR for files substitutions, CONFDIR is set earlier and defaults to /etc, now pkg-message have correct paths - Fix plist when APACHE=on PR: 206323 Submitted by: myself Approved by: maintainer Changes: head/www/foswiki/Makefile head/www/foswiki/bsd.foswiki.mk head/www/foswiki/files/pkg-message-apache.in head/www/foswiki/pkg-plist |
Created attachment 165689 [details] @dirrm & other fixes - Remove create-plist target using deprecated @dirrm - Add NO_ARCH - Don't prefix options descriptions with Installs, this makes them folllow global naming standards - Convert to options helpers - Use FOSCONFDIR for files substitutions, CONFDIR is set earlier and defaults to /etc, now pkg-message have correct paths - Fix plist when APACHE=on