Summary: | net/shadowsocks-libev: Disable TCP_FASTOPEN on FreeBSD (Fails to compile on CURRENT) | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Fukang Chen <loader> | ||||
Component: | Individual Port(s) | Assignee: | Fukang Chen <loader> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | lauheitung347, loader, xiaoding+freebsd | ||||
Priority: | --- | Keywords: | easy, patch, patch-ready | ||||
Version: | Latest | Flags: | koobs:
maintainer-feedback+
loader: merge-quarterly+ |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Fukang Chen
2016-01-17 16:38:04 UTC
(In reply to Fukang Chen from comment #0) I was in doubt whether the '__linux' macro was incorrectly introduced in latest clang compiler, since 'TCP_FASTOPEN' was defined under the #ifdef __linux directive in shadowsocks common.h header. Now the reason is clear. Thank you! Reporter is Committer, assign accordingly. Fukang, feel free to commit this (Approved by : koobs) once you are confident with QA (portlint, poudriere) and we have maintainer-approval + on the attachment You'll also want to "MFH: 2016Q1" in the commit log, and once approved, merge to quarterly. There is /usr/ports/Tools/scripts/mfh for that. Comment on attachment 165720 [details]
shadowsocks-libev-1.6.4.diff
Add maintainer-approval. Thanks!
Okay, thanks koobs@ and xiaoding. A commit references this bug: Author: loader Date: Tue Jan 19 13:53:25 UTC 2016 New revision: 406685 URL: https://svnweb.freebsd.org/changeset/ports/406685 Log: - Disable TCP_FASTOPEN to fix build on 11.0-CURRENT - Pet portlint (PORTVERSION appears out-of-order) PR: 206338 Approved by: koobs Approved by: Xiaoding Liu <xiaoding xiaoding org> (maintainer) Submitted by: loader MFH: 2016Q1 Changes: head/net/shadowsocks-libev/Makefile A commit references this bug: Author: loader Date: Tue Jan 19 15:15:49 UTC 2016 New revision: 406709 URL: https://svnweb.freebsd.org/changeset/ports/406709 Log: MFH: r406685 - Disable TCP_FASTOPEN to fix build on 11.0-CURRENT - Pet portlint (PORTVERSION appears out-of-order) PR: 206338 Approved by: koobs Approved by: Xiaoding Liu <xiaoding xiaoding org> (maintainer) Submitted by: loader Approved by: portmgr (erwin) Changes: _U branches/2016Q1/ branches/2016Q1/net/shadowsocks-libev/Makefile |