Bug 206476
| Summary: | [patch][maintainer update] science/p5-Mcstas-Tools Don't leave dead symlinks when deinstalling | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Erik B Knudsen <erkn> | ||||
| Component: | Individual Port(s) | Assignee: | Mathieu Arnold <mat> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | riggs | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
It would be better to get rid of pkg-install.in and do the following: - Have a post-install target in Makefile that creates the symlinks. - Include the symlinks in pkg-plist - use PLIST_SUB on the PORTVERSION variable pkg-install.in is a device to allow for actions which can't be foreseen at build time, but (at least in the current version) this does not apply to this port. A commit references this bug: Author: mat Date: Thu Apr 14 10:40:38 UTC 2016 New revision: 413251 URL: https://svnweb.freebsd.org/changeset/ports/413251 Log: Don't leave dead symlinks when deinstalling. [1] (based on) While there, move man pages to a place they can be used, and fix shebangs. PR: 206476 [1] Submitted by: maintainer Sponsored by: Absolight Changes: head/science/p5-Mcstas-Tools/Makefile head/science/p5-Mcstas-Tools/files/ head/science/p5-Mcstas-Tools/pkg-plist Committed a completely different patch, but one that does it right. Also, fixed a few things while I was there. |
Created attachment 165928 [details] diff generated by svn installed symbolic links were not cleaned up correctly on deinstall. Added a pkg-deinstall.in script in files to handle this.