Bug 206512
| Summary: | sysutils/coreutils: Update to 8.25 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | w.schwarzenfeld | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | jharris, mcy, nivit, pi | ||||||||||||
| Priority: | --- | Keywords: | patch-ready | ||||||||||||
| Version: | Latest | Flags: | pi:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
w.schwarzenfeld
2016-01-23 02:38:34 UTC
Created attachment 165985 [details]
poudriere-coreutils-8.25.log
Created attachment 165986 [details]
portlint-coreutils-8.25
Approved, thanks! Created attachment 166462 [details]
patch to correct OP's breakage when NLS isn't selected
This patch is approved.
Testbuilds are fine after a bit of tweaking, but there seems to be a usability change, which is discussed on the coreutils mailinglist: http://lists.gnu.org/archive/html/coreutils/2016-02/msg00000.html etc. The following ports depend on coreutils: deskutils/kdepim4/Makefile devel/quilt/Makefile devel/hs-git-annex/Makefile graphics/variety/Makefile mail/sqlgrey/Makefile misc/ansiweather/Makefile net/dropbox-uploader/Makefile net/opensips/Makefile security/openvas-plugins/Makefile sysutils/renameutils/Makefile sysutils/tenshi/Makefile sysutils/createrepo/Makefile sysutils/confman/Makefile www/mod_spdy/Makefile I wonder if they need to be tested ? portmgr, please comment: Does this need a exp-run ? The "info" change is totally wrong, please revert. And I don't think this needs an exp-run, you can test 5 or 6 of these ports yourself. Created attachment 166632 [details]
current-patch
This is the patch which I tested (has the fixed INFO).
maintainer: Can you check the usability change from the mailinglist ? Any comments on that ? Actually, with a little more grepping, I see that only sysutils/renameutils explicitly uses coreutils' gls, the only program identified in the mailing list message you referenced. Matteo has been added to this bug's CC list. All other ports explicitly (grep|awk|sort|uniq -c) use just one coreutils program: 1 gcp 2 ginstall 2 gmd5sum 1 gprintf 3 greadlink 1 grep 1 gsha256sum 1 gtail except for graphics/variety, which I have grepped and can't determine where it actually uses any of the coreutils programs (no instances of gcp, gls, etc.) So, nivit@ is also CC'd. Matteo and nivit@, will the coreutils gls change described here: http://lists.gnu.org/archive/html/coreutils/2016-02/msg00000.html break your ports I just mentioned? If you don't mind, please test against this coreutils 8.25 patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=166632&action=diff Thanks. For graphics/variety see ports/graphics/variety/files/patch-variety_VarietyWindow.py I don't think that change will break variety. A commit references this bug: Author: pi Date: Fri Feb 26 20:48:21 UTC 2016 New revision: 409637 URL: https://svnweb.freebsd.org/changeset/ports/409637 Log: sysutils/coreutils: 8.23 -> 8.25 - cp now correctly copies files with a hole at the end of the file, and extents allocated beyond the apparent size of the file. That combination resulted in the trailing hole not being reproduced. - cut --fields no longer outputs extraneous characters on some uClibc configs. - install -D again copies relative file names when absolute file names are also specified along with an absolute destination directory name. - ls no longer prematurely wraps lines when printing short file names. - mv no longer causes data loss due to removing a source directory specified multiple times, when that directory is also specified as the destination. - shred again uses defined patterns for all iteration counts. - sort --debug -b now correctly marks the matching extents for keys that specify an offset for the first field. - tail -F now works with initially non existent files on a remote file system. Please note: usability issue for 'ls' is discussed in http://lists.gnu.org/archive/html/coreutils/2016-02/msg00000.html PR: 206512 Submitted by: w.schwarzenfeld@aon.at Approved by: jharris@widomaker.com (maintainer) Changes: head/sysutils/coreutils/Makefile head/sysutils/coreutils/distinfo head/sysutils/coreutils/files/patch-configure head/sysutils/coreutils/files/patch-src_stty.c head/sysutils/coreutils/files/patch-stty.c head/sysutils/coreutils/pkg-plist Committed, thanks! |
