Bug 206622

Summary: make delete-old and WITHOUT_BSNMP=true misses links to dynamic libs
Product: Base System Reporter: Philippe Michel <philippe.michel7>
Component: miscAssignee: Enji Cooper <ngie>
Status: Closed FIXED    
Severity: Affects Only Me CC: ngie
Priority: --- Keywords: patch
Version: 10.2-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to OptionalObsoleteFiles.inc none

Description Philippe Michel 2016-01-25 21:29:31 UTC
Created attachment 166115 [details]
patch to OptionalObsoleteFiles.inc

If WITHOUT_BSNMP is set to true, make delete-old doesn't delete the links to dynamic libraries.

The attached patch allowed it to clean them up on my system. I'm not sure if there is something to do for the other .so files (snmp_lm75, snmp_hast). They were not on my system, but the left over links and my switch to WITHOUT_BSNMP were quite old ; maybe these libraries were added later.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-01-26 06:37:34 UTC
A commit references this bug:

Author: ngie
Date: Tue Jan 26 06:37:21 UTC 2016
New revision: 294770
URL: https://svnweb.freebsd.org/changeset/base/294770

Log:
  MFC r278047:

  PR: 206622
  Sponsored by: EMC / Isilon Storage Division

  r278047 (by amdmi3):

  - Remove more files when MK_BSNMP == no

Changes:
_U  stable/10/
  stable/10/tools/build/mk/OptionalObsoleteFiles.inc
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-01-26 06:39:36 UTC
A commit references this bug:

Author: ngie
Date: Tue Jan 26 06:39:11 UTC 2016
New revision: 294771
URL: https://svnweb.freebsd.org/changeset/base/294771

Log:
  MFstable/10 r294770:

  MFC r278047:

  PR: 206622

  r278047 (by amdmi3):

  - Remove more files when MK_BSNMP == no

Changes:
_U  stable/9/
_U  stable/9/tools/
_U  stable/9/tools/build/
  stable/9/tools/build/mk/OptionalObsoleteFiles.inc
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2016-01-26 06:40:09 UTC
Fixed by MFCing r278047 to ^/stable/10 and ^/stable/9. Thanks for the report!