Bug 206673
| Summary: | irc/quassel: Add optional rc var to specify the --listen argument. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Christian Schwarz <me> | ||||||||
| Component: | Individual Port(s) | Assignee: | Max Brazhnikov <makc> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | brnrd, makc, ports-bugs | ||||||||
| Priority: | --- | Keywords: | easy, patch, patch-ready | ||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(makc) koobs: merge-quarterly? |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
(In reply to me from comment #0) @Christian, yes, please bump PORTREVISION, as the package contents changes, with an updated rc script with new feature Created attachment 166423 [details]
Patch for rc script and bump in PORTREVISION.
Created attachment 166424 [details]
portlint -C output.
(In reply to Christian Schwarz from comment #0) > Created attachment 166186 [details] > quasselcore: Add optional rc var to specify the --listen argument. > > Currently, in a jail, quasselcore binds to the first IPv4 address it finds > and not to any IPv6 address. > > Furthermore, the admin has no way to specify the IP address to which > quasselcore should bind. You can override the quasselcore_args to achieve this, isn't it enough? I could add quasselcore_listen of course, but I would like to avoid introducing rc vars for every optional argument of quasselcore. (In reply to Max Brazhnikov from comment #4) Yes, you are right, one could just override the _args variable. However, here are my arguments in favor of a dedicated (optional!) _listen variable. A) The port maintainer looses flexibility in the long run. Users who override the _args variable just for --listen will not receive other changes to the launch arguments in future versions of the port. B) The default listening behavior of quasselcore is not optimal by today's standards. Only IPv4 is supported if `--listen` is not specified. We should support IPv6 wherever we can, in particular if it is so easy. Hence, if we need to specify `--listen` in _args, we might as well factor it out into a dedicated rc variable to support flexibility (-> A). In addition: c) there is no change for existing port users d) I think binding to every interface is expected default behavior for quasselcore. Hence, I (naturally) vote in favor of my patch. I hope you reconsider, Christian A commit references this bug: Author: makc Date: Mon Feb 15 11:23:34 UTC 2016 New revision: 408922 URL: https://svnweb.freebsd.org/changeset/ports/408922 Log: irc/quassel: - Add rc var to specify IP address quasselcore will listen on PR: 206673 Submitted by: Christian Schwarz Changes: head/irc/quassel/Makefile head/irc/quassel/files/quasselcore.in (In reply to Christian Schwarz from comment #5) > I hope you reconsider, Not that I'm against the patch, just wanted to see more justification for it. Committed, thanks! |
Created attachment 166186 [details] quasselcore: Add optional rc var to specify the --listen argument. Currently, in a jail, quasselcore binds to the first IPv4 address it finds and not to any IPv6 address. Furthermore, the admin has no way to specify the IP address to which quasselcore should bind. There is a '--listen' argument to quasselcore that allows specifying a list of comma-separated IPv4/6 addresses. The SVN diff attached to this bug report adds an rc variable for this argument, defaulting to '0.0.0.0,::'. This will make quasselcore listen on all IPv4/IPv6 addresses it can bind to. Note that the SVN diff does not include a bump of PORTREVISION. Should I add this?