Bug 206912
| Summary: | databases/mysql57-servers: performance_schema disabled by default | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Steven Hartland <smh> | ||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | mmokhi, riggs | ||||||
| Priority: | --- | Keywords: | needs-qa, patch-ready | ||||||
| Version: | Latest | Flags: | riggs:
merge-quarterly+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206065 | ||||||||
| Bug Depends on: | 205956 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Steven Hartland
2016-02-04 08:59:43 UTC
For reference this was changed yesterday by: r408012 (In reply to Steven Hartland from comment #1) Can this now be closed? If so, please assign to yourself Oops, I meant Thomas (riggs) for the last comment (In reply to Kubilay Kocak from comment #2) Sorry to be clear this was broken by yesterday commit r408012 (In reply to Steven Hartland from comment #4) Steven: Many people requested me to do this (disable by default in configs), as it eats about 800MB RAM by fresh install ! BTW, as both feedbacks seems reasonable to me (:D), im gonna add install time option to choose. And it's obvious that user can change it by configs at any time (this is only default config not compile/built-in setting) (In reply to Mahdi Mokhtari from comment #5) Sorry but 800MB of RAM is nothing in a production machine. If you're not just playing with or its a dev instance, then by all means provide a port option to disable it by default. For those that don't want it at runtime they can add the following to my.cnf: performance_schema=OFF There's a good reason why the default has changed ;-) (In reply to Steven Hartland from comment #6) I knew it and ive suggested those ones to do that :) BTW, as i told, im gonna enabling it again (mostly because of MySQL-dev guys suggestions and your argument [production]), AND im putting install-time option to make it disable by default :D in this way i can respect both ideas (low-resources/productions) Created attachment 166572 [details]
patch for mysql57-server adds perf_schema disable/enable option install time
patch adds perf_schema disable/enable option install time.
it also enables that by default :D
@Thomas (riggs) Up to you now, mate :D Currently double-checking pkg builds... (In reply to Thomas Zander from comment #10) Thanks :) Created attachment 166667 [details]
Revised patch using OPTION GROUPs
If I read your patch correctly, you want to have a new GROUP for essentially unrelated features instead of a RADIO.
Attached proposal changes your patch accordingly. Can you review if this is what you intended?
Generally, please consider if it is really necessary to introduce OPTION knobs for features that can be enabled or disabled via a config file and do not introduce LIB_/RUN_DEPENDS.
With every new OPTION that you introduce, more permutations of OPTIONs are possible -> More testing for the maintainer / committer prior to updates of the port Makefile, more potential ways to break the port in an unexpected way.
Honestly, my recommendation would be to support one default behaviour for the perf schema, remove the knob entirely and have users change the behaviour via the configuration file if they choose to do so.
Comment on attachment 166667 [details] Revised patch using OPTION GROUPs (In reply to Thomas Zander from comment #12) I've read your edit on patch, changed RADIO to GROUP, yes? Oh using FEATURS instead of FEATURES was intentional (to keep lines on one line, no matter :D). im okay with it :), (and ill approve it :D) > Honestly, my recommendation would be to support one default behaviour I was to do this. But honestly i've received from feedback of users (on FreeBSD community and even on MySQL community) this is a debate between production (high resource) and low resource users. And i was aware of how good (and also RAM EATING) feature perf_schema is :) So i think i had no better choice to satisfy (and respect) both big groups of users. **also if user don't choice, enable is used by default. A commit references this bug: Author: riggs Date: Sun Feb 7 08:08:21 UTC 2016 New revision: 408349 URL: https://svnweb.freebsd.org/changeset/ports/408349 Log: Revert recent change on performance_schema; introduce OPTION for it The recent port version 5.7.10_2 introduced a change in the default behaviour of performance_schema. Due to an ongoing debate in the community whether the default setting should lean towards performance (previous default before 5.7.10_2) or memory consumption, maintainer had changed the default to memory consumption in 5.7.10_2. This introduces an OPTION knob PERFSCHM to control the default behaviour of performance_schema. It defaults to ON, hence restoring the previous default. Bump PORTREVISION. PR: 206912 Submitted by: smh Reviewed by: mokhi64@gmail.com (maintainer), riggs Approved by: mokhi64@gmail.com (maintainer) MFH: 2016Q1 Changes: head/databases/mysql57-server/Makefile head/databases/mysql57-server/files/mysql-server.in head/databases/mysql57-server/pkg-message Thanks :) A commit references this bug: Author: riggs Date: Mon Feb 8 18:41:55 UTC 2016 New revision: 408495 URL: https://svnweb.freebsd.org/changeset/ports/408495 Log: MFH: r408349 Revert recent change on performance_schema; introduce OPTION for it The recent port version 5.7.10_2 introduced a change in the default behaviour of performance_schema. Due to an ongoing debate in the community whether the default setting should lean towards performance (previous default before 5.7.10_2) or memory consumption, maintainer had changed the default to memory consumption in 5.7.10_2. This introduces an OPTION knob PERFSCHM to control the default behaviour of performance_schema. It defaults to ON, hence restoring the previous default. Bump PORTREVISION. PR: 206912 Submitted by: smh Reviewed by: mokhi64@gmail.com (maintainer), riggs Approved by: ports-secteam (feld), mokhi64@gmail.com (maintainer) Changes: _U branches/2016Q1/ branches/2016Q1/databases/mysql57-server/Makefile branches/2016Q1/databases/mysql57-server/files/mysql-server.in branches/2016Q1/databases/mysql57-server/pkg-message (In reply to commit-hook from comment #16) Thanks :D |