Bug 206981

Summary: ftp/libfilezilla: fix build in cluster
Product: Ports & Packages Reporter: Matthew Rezny <rezny>
Component: Individual Port(s)Assignee: Roman Bogorodskiy <novel>
Status: Closed FIXED    
Severity: Affects Some People CC: novel
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fix ftp/libfilezilla rezny: maintainer-approval+

Description Matthew Rezny freebsd_committer freebsd_triage 2016-02-06 17:45:24 UTC 
libfilezilla was tested on 10.2 on both amd64 and i386, but surprisingly fails to build in the cluster due to an undocumented difference.

<antoine> uses=iconv is different on 10.1 and 10.2

Section 6.23 of the Porter's Handbook only mentions a difference in behavior before/after 10-current from 2013. There is no mention of the difference between 10.1 and 10.2.

Patch adds USES=iconv to allow building on 10.1 where it's not really a noop.
Comment 1 Matthew Rezny freebsd_committer freebsd_triage 2016-02-06 19:20:27 UTC 
Created attachment 166665 [details]
fix ftp/libfilezilla

This patch was attached when the issue was opened a couple hours ago. I just happened to have reloaded the page and there's no attachment. WTF bugzilla?!?
Adding it again...
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-02-07 14:35:26 UTC 
A commit references this bug:

Author: novel
Date: Sun Feb  7 14:35:15 UTC 2016
New revision: 408411
URL: https://svnweb.freebsd.org/changeset/ports/408411

Log:
  ftp/libfilezilla: fix build on 10.1

  PR:		206981
  Submitted by:	matthew@reztek.cz (maintainer)

Changes:
  head/ftp/libfilezilla/Makefile
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2016-02-07 14:38:03 UTC 
Committed, thanks!