Summary: | security/py-keyring: Update to 8.3 | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Douglas Thrift <douglas> | ||||||||||||||
Component: | Individual Port(s) | Assignee: | Ruslan Makhmatkhanov <rm> | ||||||||||||||
Status: | Closed FIXED | ||||||||||||||||
Severity: | Affects Only Me | CC: | douglas, python, rm | ||||||||||||||
Priority: | --- | Keywords: | easy, patch, patch-ready | ||||||||||||||
Version: | Latest | Flags: | koobs:
maintainer-feedback?
(douglas) |
||||||||||||||
Hardware: | Any | ||||||||||||||||
OS: | Any | ||||||||||||||||
Bug Depends on: | 207046 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
Douglas Thrift
2016-02-09 06:40:15 UTC
Created attachment 166784 [details]
security/py-keyrings.alt.shar
Here is the shar for security/py-keyrings.alt.
Created attachment 166785 [details]
logs/py27-keyring-8.3.log
Here is the poudriere testport log for security/py-keyring.
Created attachment 166786 [details]
logs/py27-keyrings.alt-1.1.log
Here is the poudriere testport log for security/py-keyrings.alt.
Thanks Douglas! Can you please create a separate issue for the NEW PORT that blocks this issue please. If py-keyrings depends on keyring.alt by default, is there still a need for an UPDATING entry? Okay, I will create a new PR for security/py-keyrings.alt. I don't think I can make security/py-keyring depend on it since that would create a circular dependency as I have it right now, but maybe I can switch that around? (In reply to douglas from comment #5) keyrings.alt doesn't appear to "require" keyrings: https://github.com/jaraco/keyrings.alt/blob/master/setup.py#L48 In this case we could look to creating an OPTION and add it to OPTIONS_DEFAULT to retain the existing behaviour/implementations (if that indeed does keep the current behaviour), which precludes needing an UPDATING entry Yep, already figuring that part out. Regarding the UPDATING thing though there is this part from CHANGES.rst: As these keyrings have moved, any keyrings indicated explicitly in configuration will need to be updated to replace "keyring.backends." with "keyrings.alt.". For example, "keyring.backends.file.PlaintextKeyring" becomes "keyrings.alt.file.PlaintextKeyring". It seems like we could have the OPTIONS_DEFAULT as well as a note about changing any configuration. Created attachment 166789 [details]
security/py27-keyring-8.3.diff
I have updated the patch so keyring now has a default option to depend on security/py-keyrings.alt which I have made a separate PR for.
Created attachment 166790 [details]
logs/py27-keyring-8.3.log
Here is the poudriere testport log for the updated diff.
Take A commit references this bug: Author: rm Date: Fri Feb 12 21:05:59 UTC 2016 New revision: 408763 URL: https://svnweb.freebsd.org/changeset/ports/408763 Log: security/py-keyring: update to 8.3 - update to 8.3 Since version 8.0, they have split some of the backends into a separate package (security/py-keyrings.alt), so change this port options accordingly. PR: 207044 Submitted by: Douglas Thrift <douglas@douglasthrift.net> (maintainer) Changes: head/security/py-keyring/Makefile head/security/py-keyring/distinfo Committed, thank you! |