Bug 207049

Summary: net-mgmt/collectd5: fix lost functionality in disk plugin
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Some People CC: pierre, ports
Priority: --- Keywords: patch
Version: LatestFlags: ports: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch ports: maintainer-approval+

Description Guido Falsi freebsd_committer freebsd_triage 2016-02-09 09:56:01 UTC 
Created attachment 166792 [details]
patch

User Pierre Guinoiseau reported on the mailing lists [1] that after the last update to the collectd5 port the disk module stopped reporting statistics it used to report.

I think the attached patch fixes the issue. Last update to the port removed a patch which is actually needed.

I'm adding Pierre and the port maintainer as CCs to this bug for testing and approval.

Thanks.


[1] https://lists.freebsd.org/pipermail/svn-ports-all/2016-February/117200.html
Comment 1 Krzysztof 2016-02-09 10:13:07 UTC 
Comment on attachment 166792 [details]
patch

OK, sorry for my mistake.
Comment 2 Pierre Guinoiseau 2016-02-09 10:20:45 UTC 
Patch tested and it works fine, my graphs are back again. :)
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2016-02-09 10:31:29 UTC 
Committed! Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-02-09 10:31:41 UTC 
A commit references this bug:

Author: madpilot
Date: Tue Feb  9 10:31:16 UTC 2016
New revision: 408548
URL: https://svnweb.freebsd.org/changeset/ports/408548

Log:
  Add back part of a patch removed by mistake.

  Allows disk module to report all disk statistics again.

  PR:		207049
  Submitted by:	me
  Reported by:	Pierre Guinoiseau <pierre at guinoiseau.eu>
  Approved by:	Krzysztof <ports at bsdserwis.com>

Changes:
  head/net-mgmt/collectd5/Makefile
  head/net-mgmt/collectd5/files/patch-src_disk.c